Continue on bad target#2418
Closed
TheTechromancer wants to merge 3 commits intodevfrom
Closed
Conversation
added 2 commits
April 22, 2025 13:55
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2418 +/- ##
=====================================
- Coverage 93% 93% -0%
=====================================
Files 383 383
Lines 30146 30149 +3
=====================================
- Hits 27869 27852 -17
- Misses 2277 2297 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Going to close this, BBOT is doing the right thing by raising a ValidationError on an empty Target list and it bubbling up to the top. The Scan should stop and the user should fix the issue with the targets passed in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a malformed target is encountered, don't halt the scan. Instead, just log a warning and continue.