Merge dev into stable: CLA workflow update#3015
Closed
Conversation
Automated Docs Update
Replace the single PR-author org membership check with a unified step that iterates all committers on the PR and checks each against: 1. GitHub API account type (type == "Bot" for App accounts) 2. Org membership Commits with no associated GitHub login are treated as non-exempt (prevents bypass via spoofed email with no GitHub account). Tested on aconite33/cla-workflow-test: - Human committer: correctly required CLA - github-actions[bot]: correctly skipped via API type check
Tested on aconite33/cla-workflow-test with only pull-requests:write and statuses:write -- both human CLA and bot skip paths work correctly. The CLA assistant uses PERSONAL_ACCESS_TOKEN (app token) for writing signatures to the remote CLA repo, not GITHUB_TOKEN.
Fix CLA workflow to skip bots and check all committers
# Conflicts: # .github/workflows/cla.yml
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## stable #3015 +/- ##
======================================
- Coverage 92% 92% -0%
======================================
Files 416 416
Lines 34690 34690
======================================
- Hits 31667 31647 -20
- Misses 3023 3043 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merges the updated CLA workflow from dev into stable (conflict resolved -- took dev version).
type == "Bot", not string matching)actions:writeandcontents:write)Already rolled out to all other org repos.