Skip to content

Remove smuggler module#3091

Merged
liquidsec merged 1 commit into
devfrom
remove-smuggler-module
May 13, 2026
Merged

Remove smuggler module#3091
liquidsec merged 1 commit into
devfrom
remove-smuggler-module

Conversation

@liquidsec
Copy link
Copy Markdown
Contributor

The smuggler tool instrumented by the smuggler module (https://github.com/defparam/smuggler) hasn't been updated in 5-6 years. The techniques it uses are outdated, and many new techniques have been discovered since. The module has also been known to have performance issues in the past.

A new tool which will replace the functionality and add in newer techniques is in early development.

Outdated and unmaintained. Will be replaced by badhttp (in early
development).
@github-actions
Copy link
Copy Markdown
Contributor

📊 Performance Benchmark Report

Comparing dev (baseline) vs remove-smuggler-module (current)

📈 Detailed Results (All Benchmarks)

📋 Complete results for all benchmarks - includes both significant and insignificant changes

🧪 Test Name 📏 Base 📏 Current 📈 Change 🎯 Status
Bloom Filter Dns Mutation Tracking Performance 4.01ms 3.92ms -2.2%
Bloom Filter Large Scale Dns Brute Force 18.18ms 18.55ms +2.1%
Large Closest Match Lookup 331.62ms 323.87ms -2.3%
Realistic Closest Match Workload 177.41ms 174.65ms -1.6%
Event Memory Medium Scan 1784 B/event 1784 B/event +0.0%
Event Memory Large Scan 1768 B/event 1768 B/event +0.0%
Event Validation Full Scan Startup Small Batch 373.14ms 372.99ms -0.0%
Event Validation Full Scan Startup Large Batch 525.56ms 524.74ms -0.2%
Make Event Autodetection Small 25.94ms 26.12ms +0.7%
Make Event Autodetection Large 264.81ms 268.65ms +1.4%
Make Event Explicit Types 11.43ms 11.50ms +0.6%
Excavate Single Thread Small 3.423s 3.429s +0.2%
Excavate Single Thread Large 9.174s 9.218s +0.5%
Excavate Parallel Tasks Small 3.627s 3.623s -0.1%
Excavate Parallel Tasks Large 6.239s 6.248s +0.1%
Is Ip Performance 2.89ms 2.92ms +0.8%
Make Ip Type Performance 10.62ms 10.73ms +1.1%
Mixed Ip Operations 4.16ms 4.22ms +1.3%
Memory Use Web Crawl 675.0 MB 669.7 MB -0.8%
Memory Use Subdomain Enum 33.3 MB 33.3 MB +0.0%
Memory Use Deep Chain 7.8 MB 7.8 MB +0.0%
Memory Use Parallel Chains 22.2 MB 21.4 MB -3.4%
Scan Throughput 100 3.719s 3.531s -5.1%
Scan Throughput 1000 27.646s 28.187s +2.0%
Typical Queue Shuffle 57.17µs 56.45µs -1.3%
Priority Queue Shuffle 624.17µs 633.35µs +1.5%

🎯 Performance Summary

No significant performance changes detected (all changes <10%)


🐍 Python Version 3.11.15

@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90%. Comparing base (e895bc0) to head (8e1ee99).
⚠️ Report is 2 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #3091   +/-   ##
=====================================
- Coverage     90%     90%   -0%     
=====================================
  Files        446     444    -2     
  Lines      38377   38338   -39     
=====================================
- Hits       34319   34282   -37     
+ Misses      4058    4056    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ausmaster ausmaster self-requested a review May 13, 2026 17:41
@liquidsec liquidsec merged commit e892c8c into dev May 13, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants