Skip to content

Bump blasthttp to 0.6.0, pass files= through WebHelper#3093

Open
liquidsec wants to merge 1 commit into
devfrom
blasthttp-0.6.0
Open

Bump blasthttp to 0.6.0, pass files= through WebHelper#3093
liquidsec wants to merge 1 commit into
devfrom
blasthttp-0.6.0

Conversation

@liquidsec
Copy link
Copy Markdown
Contributor

Summary

  • Bumps blasthttp to >=0.6.0 (https://github.com/blacklanternsecurity/blasthttp/pull/24).
  • WebHelper.request() drops the silent files= not supported warning and forwards files= to blasthttp. body=bytes flows through as bytes (was forced to str(body)).
  • mock_blasthttp.py stops stripping files= and mirrors WebHelper's body/files handling so test mocks see the same encoded multipart body the wire would.
  • New test_web_request_files_multipart end-to-end test posts a multipart payload via self.helpers.request(files=...) against a real bbot_httpserver and asserts the wire body parts + Content-Type: multipart/form-data; boundary=….

This unblocks bbot/modules/telerik.py:229, which sends an httpx-style files= probe and was silently sending an empty POST under the blasthttp integration.

- WebHelper.request() drops the silent files= warning and forwards
  files= to blasthttp; body=bytes also flows through as bytes
- mock_blasthttp.py stops stripping files= and now mirrors
  WebHelper's body/files handling for the in-process test mock
- new test_web_request_files_multipart end-to-end test posts a
  multipart payload via self.helpers.request(files=...) and
  asserts the wire body and Content-Type boundary
@github-actions
Copy link
Copy Markdown
Contributor

📊 Performance Benchmark Report

Comparing dev (baseline) vs blasthttp-0.6.0 (current)

📈 Detailed Results (All Benchmarks)

📋 Complete results for all benchmarks - includes both significant and insignificant changes

🧪 Test Name 📏 Base 📏 Current 📈 Change 🎯 Status
Bloom Filter Dns Mutation Tracking Performance 4.24ms 4.24ms +0.1%
Bloom Filter Large Scale Dns Brute Force 17.56ms 18.61ms +6.0%
Large Closest Match Lookup 336.49ms 336.51ms +0.0%
Realistic Closest Match Workload 178.68ms 179.97ms +0.7%
Event Memory Medium Scan 1784 B/event 1784 B/event +0.0%
Event Memory Large Scan 1768 B/event 1768 B/event +0.0%
Event Validation Full Scan Startup Small Batch 375.28ms 394.78ms +5.2%
Event Validation Full Scan Startup Large Batch 507.16ms 530.27ms +4.6%
Make Event Autodetection Small 25.20ms 25.44ms +0.9%
Make Event Autodetection Large 256.54ms 256.23ms -0.1%
Make Event Explicit Types 10.73ms 10.88ms +1.4%
Excavate Single Thread Small 3.442s 3.461s +0.6%
Excavate Single Thread Large 8.706s 8.678s -0.3%
Excavate Parallel Tasks Small 3.678s 3.653s -0.7%
Excavate Parallel Tasks Large 6.093s 6.063s -0.5%
Is Ip Performance 3.18ms 3.24ms +1.8%
Make Ip Type Performance 11.41ms 11.45ms +0.4%
Mixed Ip Operations 4.49ms 4.57ms +1.8%
Memory Use Web Crawl 649.8 MB 633.8 MB -2.5%
Memory Use Subdomain Enum 33.3 MB 33.3 MB -0.0%
Memory Use Deep Chain 7.8 MB 7.8 MB +0.1%
Memory Use Parallel Chains 21.8 MB 23.0 MB +5.4%
Scan Throughput 100 3.601s 3.634s +0.9%
Scan Throughput 1000 27.470s 27.564s +0.3%
Typical Queue Shuffle 61.74µs 60.30µs -2.3%
Priority Queue Shuffle 730.55µs 712.15µs -2.5%

🎯 Performance Summary

No significant performance changes detected (all changes <10%)


🐍 Python Version 3.11.15

@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

❌ Patch coverage is 93.33333% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90%. Comparing base (e895bc0) to head (2dc7d3d).
⚠️ Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
bbot/test/mock_blasthttp.py 85% 3 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #3093   +/-   ##
=====================================
- Coverage     90%     90%   -0%     
=====================================
  Files        446     444    -2     
  Lines      38377   38367   -10     
=====================================
- Hits       34319   34304   -15     
- Misses      4058    4063    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant