Bump blasthttp to 0.6.0, pass files= through WebHelper#3093
Merged
Conversation
- WebHelper.request() drops the silent files= warning and forwards files= to blasthttp; body=bytes also flows through as bytes - mock_blasthttp.py stops stripping files= and now mirrors WebHelper's body/files handling for the in-process test mock - new test_web_request_files_multipart end-to-end test posts a multipart payload via self.helpers.request(files=...) and asserts the wire body and Content-Type boundary
Contributor
📊 Performance Benchmark Report
📈 Detailed Results (All Benchmarks)
🎯 Performance Summary✅ No significant performance changes detected (all changes <10%) 🐍 Python Version 3.11.15 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #3093 +/- ##
=====================================
+ Coverage 90% 90% +1%
=====================================
Files 444 444
Lines 38338 38383 +45
=====================================
+ Hits 34277 34320 +43
- Misses 4061 4063 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ausmaster
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
blasthttpto>=0.6.0(Add httpx-style files= multipart support + ruff (v0.6.0) blasthttp#24).WebHelper.request()drops the silentfiles= not supportedwarning and forwardsfiles=to blasthttp.body=bytesflows through as bytes (was forced tostr(body)).mock_blasthttp.pystops strippingfiles=and mirrors WebHelper's body/files handling so test mocks see the same encoded multipart body the wire would.test_web_request_files_multipartend-to-end test posts a multipart payload viaself.helpers.request(files=...)against a realbbot_httpserverand asserts the wire body parts +Content-Type: multipart/form-data; boundary=….This unblocks
bbot/modules/telerik.py:229, which sends an httpx-stylefiles=probe and was silently sending an empty POST under the blasthttp integration.