remove warnings

Author: mean

src/command.c

@@ -63,6 +63,9 @@ static bool cmd_jtag_scan(target_s *target, int argc, const char **argv);
 static bool cmd_swd_scan(target_s *target, int argc, const char **argv);
 #if defined(CONFIG_RVSWD) && defined(PLATFORM_HAS_RVSWD)
 static bool cmd_rvswd_scan(target_s *target, int argc, const char **argv);
+#if CONFIG_BMDA == 0
+bool bmp_rvswd_scan(void);
+#endif
 #endif
 static bool cmd_onboard_flash_scan(target_s *target, int argc, const char **argv);
 static bool cmd_auto_scan(target_s *target, int argc, const char **argv);
@@ -423,6 +426,9 @@ bool cmd_auto_scan(target_s *target, int argc, const char **argv)
 	{
 		{jtag_scan, "JTAG"},
 		{adiv5_swd_scan, "SWD"},
+#if defined(CONFIG_RVSWD) && defined(PLATFORM_HAS_RVSWD)
+		{bmp_rvswd_scan, "RVSWD"},
+    #endif
 	};
 	/* clang-format on */
 #endif

src/platforms/common/rvswdptap.c

@@ -112,11 +112,6 @@ static bool rv_start_frame(uint32_t adr, bool wr)
 	return true;
 }
 
-/**
- * @brief read 4 status bit then send a stop bit
- *
- * @return uint32_t
- */
 static bool rv_end_frame(uint32_t *status)
 {
 	uint32_t out = 0;
@@ -133,8 +128,6 @@ static bool rv_end_frame(uint32_t *status)
 	return out;
 }
 
-/**
- */
 bool rv_dm_write(uint32_t adr, uint32_t val)
 {
 	rv_start_frame(adr, true);
@@ -155,14 +148,6 @@ bool rv_dm_write(uint32_t adr, uint32_t val)
 	return true;
 }
 
-/**
- * @brief
- *
- * @param adr
- * @param output
- * @return true
- * @return false
- */
 bool rv_dm_read(uint32_t adr, uint32_t *output)
 {
 	rv_start_frame(adr, false);
@@ -182,8 +167,8 @@ static bool rv_dm_probe(uint32_t *chip_id)
 {
 	*chip_id = 0;
 	uint32_t out = 0; // scratch
-	//
-	rv_dm_write(0x10, 0x80000001UL); // write DM CTROL =1
+	// This follows exactly what the wchlink does
+	rv_dm_write(0x10, 0x80000001UL); // write DM CTRL = 0x800000001
 	platform_delay(1);
 	rv_dm_write(0x10, 0x80000001UL); // write DM CTRL = 0x800000001
 	platform_delay(1);