Refactor demo recorder, add Android export

Refactors demo_scene.gd for clearer structure and Android-safe saving, and improves 24-bit playback buffering.

- Split initialization into helpers: platform permission request (_initialize_platform_permissions), UI setup, and processing (_process -> _update_volume_meter_logic).
- Add ANDROID_RECORDINGS_SUBDIR constant and implement Android export workflow: save to a temporary user:// file, then copy to Documents/recordings (creating the dir if needed) to work around scoped storage. Uses a short crypto-based id for filenames.
- Centralize UI state changes with _toggle_playback_controls and simplify device selection handlers.
- Add scene connection for output device selection in demo_scene.tscn.
- Improve AudioStreamPlayerWav24B: track when all frames were pushed, avoid hanging by finalizing playback when server buffer empties, reset state on play/seek, and push buffers more robustly.
- Add assets/.gdignore and remove two unused .import files (banner.webp.import, icon.png.import).

These changes improve Android compatibility, UI responsiveness, and reliability of 24-bit playback.

Author: blacknoize404

addons/direct_audio_and_wav_24bits/demo/demo_scene.gd

@@ -3,18 +3,22 @@ extends Control
 ## Example scene demonstrating the 24-bit high-fidelity recording workflow.
 ## This script handles UI updates, recording states, and file management.
 
+# --- Constants ---
+const ANDROID_RECORDINGS_SUBDIR = "recordings"
+
 # --- UI References ---
 @onready var start_and_stop_button: Button = %StartAndStopButton
 @onready var play_stop_button: Button = %PlayStopButton
 @onready var save_button: Button = %SaveButton
 @onready var format_option_button: OptionButton = %OptionButton
 @onready var volume_progress_bar: ProgressBar = %ProgressBar
+
 @onready var input_hz_label: Label = %InputHz
 @onready var output_hz_label: Label = %OutputHz
+
 @onready var input_devices_option: OptionButton = %InputDevicesOption
 @onready var output_devices_option: OptionButton = %OutputDevicesOption
 
-
 # --- Audio References ---
 @onready var recorder: DirectAudioInputRecorder = $DirectAudioInputRecorder
 @onready var player_24bit: AudioStreamPlayerWav24B = $AudioStreamPlayerWav24B
@@ -31,13 +35,19 @@ var _last_recorded_resource: AudioStreamWAV
 
 func _ready() -> void:
 
-	if OS.get_name() == "Android":
-		OS.request_permissions()
-		
+	_initialize_platform_permissions()
 	_setup_ui_initial_state()
 	_populate_format_options()
 	_load_devices()
 
+func _process(delta: float) -> void:
+	_update_volume_meter_logic(delta)
+	
+func _initialize_platform_permissions() -> void:
+	if OS.get_name() == "Android":
+		# Requesting multiple permissions often needed for audio/storage
+		OS.request_permissions()
+	
 func _setup_ui_initial_state() -> void:
 	input_hz_label.text = str(AudioServer.get_input_mix_rate())
 	output_hz_label.text = str(AudioServer.get_mix_rate())
@@ -64,25 +74,16 @@ func _populate_format_options() -> void:
 
 	format_option_button.selected = recorder.format
 
-# --- Main Loop ---
+# --- Logic & Processing ---
 
-func _process(delta: float) -> void:
-	# Update the peak meter in real-time
-	var peak_db = recorder.get_peak_volume_db().x
-	_update_volume_meter(peak_db, delta)
-
-# --- UI Logic ---
-
-func _update_volume_meter(peak_db: float, delta: float) -> void:
-	var energy = db_to_linear(peak_db)
-	var current_val = volume_progress_bar.value
+func _update_volume_meter_logic(delta: float) -> void:
+	var peak_db: float = recorder.get_peak_volume_db().x
+	var energy := db_to_linear(peak_db)
+	var current_val := volume_progress_bar.value
 
-	# Instant rise, smooth fall (classic peak meter behavior)
-	#if energy > current_val:
-		#volume_progress_bar.value = energy
-	#else:
+	# Smooth fall-off for the meter visualization
 	volume_progress_bar.value = lerp(current_val, energy, meter_smooth_speed * delta)
-
+	
 # --- Signal Callbacks: Recorder ---
 
 func _on_start_and_stop_button_pressed() -> void:
@@ -94,19 +95,23 @@ func _on_start_and_stop_button_pressed() -> void:
 func _on_recorder_on_recording_start() -> void:
 	start_and_stop_button.text = "Stop Recording"
 	start_and_stop_button.modulate = Color.RED
-	play_stop_button.disabled = true
-	save_button.disabled = true
+	_toggle_playback_controls(true)
 
 func _on_recorder_on_recording_end() -> void:
 	start_and_stop_button.text = "Record"
 	start_and_stop_button.modulate = Color.WHITE
 
-	# Generate the 24-bit resource immediately after recording
+	# Cache recorded resources
 	_last_recorded_resource24b = recorder.get_recording_as_wav24b()
 	_last_recorded_resource = recorder.get_recording()
 
-	play_stop_button.disabled = false
-	save_button.disabled = false
+	_toggle_playback_controls(false)
+
+func _toggle_playback_controls(is_recording: bool) -> void:
+	play_stop_button.disabled = is_recording
+	save_button.disabled = is_recording
+
+# --- Signal Callbacks: Playback ---
 
 # --- Signal Callbacks: Playback ---
 
@@ -117,7 +122,7 @@ func _on_play_stop_button_pressed() -> void:
 		_stop_playback()
 
 func _start_playback() -> void:
-	if _last_recorded_resource:
+	if _last_recorded_resource24b:
 		player_24bit.play_24bit(_last_recorded_resource24b)
 		play_stop_button.text = "Stop Playback"
 		_is_playing = true
@@ -130,57 +135,62 @@ func _stop_playback() -> void:
 func _on_player_24bit_finished() -> void:
 	_stop_playback()
 
-# --- Signal Callbacks: File Management ---
+# --- File Management & Android Workaround ---
 
 func _on_save_button_pressed() -> void:
 	if not _last_recorded_resource:
+		push_warning("No recording available to save.")
 		return
 
-	var file_name = "recording_%s.wav" % _generate_uuid().substr(0, 8)
+	var file_name := "rec_%s.wav" % _generate_short_id()
+	var temp_path := "user://" + file_name
+	var save_error: Error
 
-	var file_path = "user://" + file_name
+	# 1. High-speed internal save (Direct IO)
+	if recorder.format == 2: # 24-bit format index
+		save_error = _last_recorded_resource24b.save_to_wav(temp_path)
+	else:
+		save_error = _last_recorded_resource.save_to_wav(temp_path)
 
+	if save_error != OK:
+		push_error("Failed to save temporary file. Error: ", save_error)
+		return
+
+	# 2. Android Scoped Storage Workaround
 	if OS.get_name() == "Android":
-		file_path = OS.get_system_dir(OS.SYSTEM_DIR_DOCUMENTS) + "/recordings/" + file_name
+		_export_to_android_documents(temp_path, file_name)
+	else:
+		print("File saved to user data: ", ProjectSettings.globalize_path(temp_path))
+
+# Moves a file from internal storage to the public Documents folder on Android.
+func _export_to_android_documents(source_path: String, file_name: String) -> void:
+	var docs_dir := OS.get_system_dir(OS.SYSTEM_DIR_DOCUMENTS).path_join(ANDROID_RECORDINGS_SUBDIR)
 
-	var error
+	# Ensure directory exists
+	if not DirAccess.dir_exists_absolute(docs_dir):
+		DirAccess.make_dir_recursive_absolute(docs_dir)
 
-	if (recorder.format == 2):
-		error = _last_recorded_resource24b.save_to_wav(file_path)
-	else:
-		error = _last_recorded_resource.save_to_wav(file_path)
+	var destination_path := docs_dir.path_join(file_name)
+	var dir := DirAccess.open("user://")
 
-	if error == OK:
-		print("Success: %s audio saved at: " % recorder.available_formats()[recorder.format], ProjectSettings.globalize_path(file_path))
+	if dir and dir.copy(source_path, destination_path) == OK:
+		print("Successfully exported to Documents: ", destination_path)
+		dir.remove(source_path) # Clean up temp file
 	else:
-		push_error("Failed to save audio. Error code: ", error)
+		push_error("Android Export Failed. Path: ", destination_path)
 
 func _on_option_button_item_selected(index: int) -> void:
 	recorder.format = index
 
 # --- Helpers ---
 
-## Generates a unique identifier for file naming.
-func _generate_uuid() -> String:
-	var crypto = Crypto.new()
-	var b = crypto.generate_random_bytes(16)
-	
-	# UUID v4 specific bit manipulation
-	b[6] = (b[6] & 0x0f) | 0x40
-	b[8] = (b[8] & 0x3f) | 0x80
-	
-	var hex = b.hex_encode()
-	return "%s-%s-%s-%s-%s" % [
-		hex.substr(0, 8), hex.substr(8, 4), 
-		hex.substr(12, 4), hex.substr(16, 4), 
-		hex.substr(20, 12)
-	]
+## Generates a short random ID using crypto-safe bytes.
+func _generate_short_id() -> String:
+	var crypto := Crypto.new()
+	return crypto.generate_random_bytes(4).hex_encode()
 
 func _on_input_devices_option_item_selected(index: int) -> void:
-	var s = input_devices_option.get_item_text(index)
-	AudioServer.input_device = s
-	
+	AudioServer.input_device = input_devices_option.get_item_text(index)
 
 func _on_output_devices_option_item_selected(index: int) -> void:
-	var e = output_devices_option.get_item_text(index)
-	AudioServer.output_device = e
+	AudioServer.output_device = output_devices_option.get_item_text(index)

addons/direct_audio_and_wav_24bits/demo/demo_scene.tscn

@@ -211,3 +211,4 @@ text_overrun_behavior = 4
 [connection signal="pressed" from="CenterContainer/PanelContainer/MarginContainer/VBoxContainer/HBoxContainer/VBoxContainer/PanelContainer/MarginContainer/VBoxContainer/SaveButton" to="." method="_on_save_button_pressed"]
 [connection signal="item_selected" from="CenterContainer/PanelContainer/MarginContainer/VBoxContainer/HBoxContainer/VBoxContainer/PanelContainer/MarginContainer/VBoxContainer/HBoxContainer/OptionButton" to="." method="_on_option_button_item_selected"]
 [connection signal="item_selected" from="CenterContainer/PanelContainer/MarginContainer/VBoxContainer/PanelContainer/MarginContainer/VBoxContainer/HBoxContainer3/HBoxContainer/InputDevicesOption" to="." method="_on_input_devices_option_item_selected"]
+[connection signal="item_selected" from="CenterContainer/PanelContainer/MarginContainer/VBoxContainer/PanelContainer/MarginContainer/VBoxContainer/HBoxContainer3/HBoxContainer2/OutputDevicesOption" to="." method="_on_output_devices_option_item_selected"]

addons/direct_audio_and_wav_24bits/scripts/audio_stream_player_wav_24b.gd

@@ -15,6 +15,7 @@ var stream_resource: AudioStreamWAV24B
 var _playback: AudioStreamGeneratorPlayback
 var _current_frame_index: int = 0
 var _is_initialized: bool = false
+var _was_pushed_completely: bool = false
 
 # --- Built-in Node Methods ---
 
@@ -35,6 +36,7 @@ func play_24bit(res: AudioStreamWAV24B) -> void:
 
 	stream_resource = res
 	_current_frame_index = 0
+	_was_pushed_completely = false # Resetear estado
 
 	# Ensure the generator's mix rate matches the resource
 	if stream.mix_rate != res.mix_rate:
@@ -49,12 +51,14 @@ func play_24bit(res: AudioStreamWAV24B) -> void:
 ## Resets the playback cursor to the beginning.
 func seek_start() -> void:
 	_current_frame_index = 0
+	_was_pushed_completely = false
 
 # --- Internal Methods ---
 
 ## Initializes the AudioStreamGenerator which acts as a bridge for the raw data.
 func _setup_generator() -> void:
 	var generator = AudioStreamGenerator.new()
+	
 	generator.mix_rate = 44100 # Default, will be updated on play
 	generator.buffer_length = 0.1 # 100ms buffer for low latency
 
@@ -73,14 +77,30 @@ func _fill_buffer() -> void:
 
 	# Calculate how many frames are left in the actual audio data
 	var total_resource_frames = stream_resource.data.size() / (6 if stream_resource.stereo else 3)
+
+	# 1. ¿Ya enviamos todo al buffer?
+	if _current_frame_index >= total_resource_frames:
+		_was_pushed_completely = true
+		
+		# 2. Esperar a que el buffer del AudioServer se vacíe
+		# Si los frames disponibles son iguales al tamaño total del buffer, es que ya no hay nada sonando
+		var buffer_capacity = stream.buffer_length * stream.mix_rate
+		if frames_available >= buffer_capacity - 1: # -1 por margen de error de redondeo
+			_finalize_playback()
+		return
+		
+	if frames_available <= 0:
+		return
+	
 	var frames_to_process = min(frames_available, total_resource_frames - _current_frame_index)
 
 	if frames_to_process <= 0:
 		if _current_frame_index >= total_resource_frames:
 			# End of file reached
 			stop()
 		return
-
+		
+	# --- DECODING LOOP ---
 	# Create a temporary buffer for the chunk
 	var chunk = PackedVector2Array()
 	chunk.resize(frames_to_process)
@@ -112,3 +132,9 @@ func _fill_buffer() -> void:
 	# Push the decoded chunk to the AudioServer
 	_playback.push_buffer(chunk)
 	_current_frame_index += frames_to_process
+	
+func _finalize_playback() -> void:
+	stop()
+	_current_frame_index = 0
+	_was_pushed_completely = false
+	finished.emit()