Skip to content

Fix tl/tq/td flag injection for Temporal CLI#11

Merged
bicabone merged 1 commit into
mainfrom
fix/temporal-flag-injection-order-and-empty-fields
Mar 3, 2026
Merged

Fix tl/tq/td flag injection for Temporal CLI#11
bicabone merged 1 commit into
mainfrom
fix/temporal-flag-injection-order-and-empty-fields

Conversation

@bicabone
Copy link
Copy Markdown
Contributor

@bicabone bicabone commented Mar 3, 2026

Summary

  • fix wrapped temporal invocation to inject context flags after the top-level command (temporal workflow --address ... list) to match Temporal CLI behavior
  • keep root/option-only invocations (temporal, temporal --help) unwrapped
  • ensure _temporalctx_build_flags always returns success when config parsing succeeds, even when optional fields are missing
  • add regression test: missing context fields do not produce empty-value flags

Repro and validation

  • previous failing path: tl produced unknown flag: --address
  • verified tl now works against real CLI
  • ran ./tests/run.sh and all tests pass

@bicabone bicabone merged commit e0f2e6b into main Mar 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant