fix: PatchOperationList should decode patches as objects

Because although the top-level patch entries will be equivalent as
arrays or objects, properties like the `value` key can contain any type
of data.

Author: acoulton

src/operations/PatchOperationList.php

@@ -6,6 +6,7 @@
 use blancks\JsonPatch\exceptions\InvalidPatchOperationException;
 use blancks\JsonPatch\json\handlers\BasicJsonHandler;
 use blancks\JsonPatch\json\handlers\JsonHandlerInterface;
+use stdClass;
 
 final class PatchOperationList implements \JsonSerializable
 {
@@ -25,7 +26,7 @@ public static function fromJson(
         JsonHandlerInterface $jsonHandler = new BasicJsonHandler(),
         array $customClasses = [],
     ): self {
-        $patches = $jsonHandler->decode($jsonOperations, ['associative' => true]);
+        $patches = $jsonHandler->decode($jsonOperations);
         if (!(is_array($patches) && array_is_list($patches))) {
             throw new InvalidPatchException(
                 sprintf('Invalid patch structure (expected list, got %s)', get_debug_type($patches)),
@@ -44,7 +45,10 @@ public static function fromJson(
 
         return new PatchOperationList(
             ...array_map(
-                function (array $patch) use ($classes) {
+                function (stdClass $patch) use ($classes) {
+                    // The top-level patch entries should be identical as objects or arrays, cast to array to allow
+                    // spreading the properties into the DTO constructors (which are assumed to match the JSON objects)
+                    $patch = (array) $patch;
                     $op = $patch['op'];
                     unset($patch['op']);
                     if (!isset($classes[$op])) {

tests/operations/PatchOperationListTest.php

@@ -25,6 +25,7 @@
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Assert;
 use PHPUnit\Framework\Attributes\UsesClass;
+use stdClass;
 use Throwable;
 
 #[CoversClass(PatchOperationList::class)]
@@ -51,6 +52,10 @@ class PatchOperationListTest extends JsonPatchCompliance
      */
     public static function validEncodeDecodeProvider(): array
     {
+        $objValue = new stdClass();
+        $objValue->type = 'foo';
+        $objValue->list = ['bar', 'baz'];
+
         return [
             'empty list' => [
                 [],
@@ -82,6 +87,20 @@ public static function validEncodeDecodeProvider(): array
                 ]
                 JSON,
             ],
+            'operations with object values' => [
+                [
+                    new Add(path: '/bar', value: $objValue),
+                    new Replace(path: '/bar', value: $objValue),
+                    new Test(path: '/bar', value: $objValue),
+                ],
+                <<<'JSON'
+                [
+                  {"op":"add","path":"/bar","value":{"type":"foo","list":["bar","baz"]}},
+                  {"op":"replace","path":"/bar","value":{"type":"foo","list":["bar","baz"]}},
+                  {"op":"test","path":"/bar","value":{"type":"foo","list":["bar","baz"]}}
+                ]
+                JSON,
+            ]
         ];
     }
 
@@ -150,13 +169,13 @@ public function decode(string $json, array $options = []): mixed
                     Assert::assertSame(
                         [
                             'json' => '[fake]',
-                            'options' => ['associative' => true],
+                            'options' => [],
                         ],
                         get_defined_vars(),
                         'JSONHandler should have been called with expected args',
                     );
                     return [
-                        ['op' => 'remove', 'path' => '/some/path'],
+                        (object) ['op' => 'remove', 'path' => '/some/path'],
                     ];
                 }
             },
@@ -170,23 +189,6 @@ public function decode(string $json, array $options = []): mixed
 
     public function testItCanDecodeWithCustomOperationClasses(): void
     {
-        $appendOperation = new class('/greeting', ' World') extends PatchOperation {
-            public function __construct(
-                public readonly string $path,
-                public readonly string $suffix,
-            ) {
-                parent::__construct('append');
-            }
-        };
-        $customAddOperation = new class('/greeting', 'Hello') extends PatchOperation {
-            public function __construct(
-                public readonly string $path,
-                public readonly mixed $value,
-            ) {
-                parent::__construct('add');
-            }
-        };
-
         $result = PatchOperationList::fromJson(
             <<<'JSON'
             [
@@ -196,15 +198,15 @@ public function __construct(
             ]
             JSON,
             customClasses: [
-                'add' => $customAddOperation::class,
-                'append' => $appendOperation::class,
+                'add' => CustomAdd::class,
+                'append' => Append::class,
             ],
         );
 
         $this->assertEquals(
             new PatchOperationList(
-                $customAddOperation,
-                $appendOperation,
+                new CustomAdd('/greeting', 'Hello'),
+                new Append('/greeting', ' World'),
                 new Copy(path: '/whatever', from: '/greeting'),
             ),
             $result,
@@ -220,13 +222,18 @@ public static function invalidJsonProvider(): array
             'json is not a list (example 1)' => [
                 '{"some": "field"}',
                 InvalidPatchException::class,
-                'Invalid patch structure (expected list, got array)',
+                'Invalid patch structure (expected list, got stdClass)',
             ],
             'json is not a list (example 2)' => [
                 'true',
                 InvalidPatchException::class,
                 'Invalid patch structure (expected list, got bool)',
             ],
+            'json is not a list (example 3)' => [
+                '{"2": {"op": "add", "path": "/some/path", "value": "World"}}',
+                InvalidPatchException::class,
+                'Invalid patch structure (expected list, got stdClass)',
+            ],
             'unknown operation' => [
                 '[{"op": "scramble", "path": "/anywhere"}]',
                 InvalidPatchOperationException::class,