fix(server): correctly resolve workspace folder URI on Windows#76
Merged
blazejkustra merged 2 commits intomainfrom May 3, 2026
Merged
fix(server): correctly resolve workspace folder URI on Windows#76blazejkustra merged 2 commits intomainfrom
blazejkustra merged 2 commits intomainfrom
Conversation
Use Node's fileURLToPath to convert the LSP workspace folder URI to a filesystem path, replacing the manual slice(7) that left URL-encoded characters in place and kept the leading slash on Windows drive paths. Fixes #68.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fileURLToPathto convert the LSP workspace folder URI to a filesystem path, replacing the manualslice(7)that left URL-encoded characters in place and kept the leading slash on Windows drive paths.file:///c%3A/repos/...was being turned into/c%3A/repos/..., sopath.join(workspaceFolder, "node_modules/babel-plugin-react-compiler")produced\c%3A\repos\...\node_modules\babel-plugin-react-compilerand the require failed.Test plan
tsc --noEmitpasses inpackages/server.