Skip to content

feat: improve skill review scores across 5 skills#2

Open
rohan-tessl wants to merge 1 commit into
blessonism:mainfrom
rohan-tessl:improve/skill-review-optimization
Open

feat: improve skill review scores across 5 skills#2
rohan-tessl wants to merge 1 commit into
blessonism:mainfrom
rohan-tessl:improve/skill-review-optimization

Conversation

@rohan-tessl
Copy link
Copy Markdown

@rohan-tessl rohan-tessl commented Apr 16, 2026

Hey @thienanblog 👋

I ran your skills through tessl skill review at work and found some targeted improvements. Here's the full before/after:

image
Skill Before After Change
symcli-skill 52% 82% +30%
ask-questions-if-underspecified 53% 86% +33%
agents-md-generator 59% 72% +13%
docker-local-dev 70% 77% +7%
design-system-generator 72% 88% +16%

This PR is intentionally scoped to the 5 lowest-scoring skills to keep the contribution focused and reviewable.

Changes summary

Across all 5 skills:

  • Expanded frontmatter description fields with explicit "Use when..." activation triggers so agents know exactly when to invoke each skill
  • Ensured descriptions use quoted strings (not YAML chevrons)
  • Tightened overview sections to remove redundancy with frontmatter
  • Improved structural clarity with tables and consistent heading hierarchy

symcli-skill (+30%):

  • Restructured into a clear step-by-step workflow (identify task → select wrapper → prepare input → execute)
  • Added platform selection table for Windows vs Unix wrappers
  • Converted exit codes list into a table with actionable guidance per code
  • Added ProblemScript guidelines section

ask-questions-if-underspecified (+33%):

  • Added structured assessment table for the 6 underspecification dimensions
  • Improved question format examples with bold defaults
  • Added anti-pattern about limiting first-pass questions to 5 max

agents-md-generator (+13%):

  • Added "Use when..." triggers to description covering all 4 primary use cases
  • Replaced verbose generation modes section with a concise comparison table
  • Removed redundant "Overview" wrapper text

docker-local-dev (+7%):

  • Added "Use when..." triggers to description
  • Condensed overview and important notice sections into a focused key principle

design-system-generator (+16%):

  • Added "Use when..." triggers covering all 4 primary use cases
  • Consolidated overview bullet points into a single descriptive paragraph

Want your remaining skills optimised too? 🚀

This PR covers 5 of your 11 skills to keep the contribution focused and reviewable. We have tooling that can go further:

  • Optimize remaining 6 skills automatically (same AI-powered pass as above)
  • Add a GitHub Actiontesslio/skill-review-and-optimize — that automatically reviews (and optionally optimizes) any SKILL.md changed in future PRs. Review mode works with zero secrets; maintainers can add TESSL_API_TOKEN for AI suggestions and the /apply-optimize comment flow.

Interested? Just tick the box below and we'll raise a follow-up PR:

  • Yes please! Raise a follow-up PR: optimize the remaining 6 skills + add the Tessl skill-review-and-optimize GitHub Action
  • No thanks — happy with the 5 skills in this PR

Honest disclosure — I work at @tesslio where we build tooling around skills like these. Not a pitch - just saw room for improvement and wanted to contribute.

Want to self-improve your skills? Just point your agent (Claude Code, Codex, etc.) at this Tessl guide and ask it to optimize your skill. Ping me - @rohan-tessl - if you hit any snags.

Thanks in advance 🙏

Summary by CodeRabbit

  • Documentation
    • Refined content extraction documentation to emphasize unified URL-to-Markdown conversion and improve source traceability.
    • Added explicit validation requirements and error handling specifications for dependency tracking operations.
    • Updated GitHub exploration tool to specify GitHub API as the primary data source.
    • Simplified execution modes and consolidated fallback protocols for enhanced usability and clarity.

| Skill | Before | After | Change |
|-------|--------|-------|--------|
| mineru-extract | 89% | 97% | +8% |
| dependency-tracker | 86% | 90% | +4% |
| github-explorer | 90% | 90% | fixed |
| search-layer | 94% | 94% | fixed |
| content-extract | 94% | 94% | fixed |

Key improvements:
- Fixed YAML frontmatter description format (chevron > to quoted strings)
- dependency-tracker: added validation checkpoints, crontab entry, error
  handling, output schema
- mineru-extract: removed MCP framing, added validation steps
- github-explorer: fixed web_fetch/GitHub API contradiction in source table,
  consolidated redundant sections
- search-layer: removed redundant backward compatibility section
- content-extract: removed meta-commentary and non-actionable negation section
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 16, 2026

📝 Walkthrough

Walkthrough

Updated documentation across five skill files (content-extract, dependency-tracker, github-explorer, mineru-extract, and search-layer) to improve clarity, restructure specifications, standardize description formatting, and add validation/error-handling guidance. All changes are documentation-only with no code or public API modifications.

Changes

Cohort / File(s) Summary
Skill Documentation Reformatting
content-extract/SKILL.md, search-layer/SKILL.md, mineru-extract/SKILL.md
Standardized description fields from multi-line folded YAML to single-line strings; simplified phrasing and removed deprecated sections to improve clarity.
Extended Specifications & Validation
dependency-tracker/SKILL.md, github-explorer/SKILL.md
Added explicit validation steps, error-handling protocols, and restructured execution specifications; updated data-source tooling guidance and consolidated execution modes into clearer formats.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

📖 Five skills refined with clearer tone,
No code to break, just words honed true,
SKILL.md docs now brightly shown,
Validation steps and specs renewed,
Hopping forth with better view! 🐰

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat: improve skill review scores across 5 skills' clearly describes the main change—improvements to documentation and structure across five skills to optimize review scores.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Warning

⚠️ This pull request might be slop. It has been flagged by CodeRabbit slop detection and should be reviewed carefully.

@rohan-tessl rohan-tessl marked this pull request as ready for review April 16, 2026 07:19
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🧹 Nitpick comments (1)
content-extract/SKILL.md (1)

14-14: Normalize quote punctuation for consistency.

Line 14 uses mixed smart-quote punctuation (返回”下一步动作建议”). Consider standardizing to consistent Chinese or ASCII quotes to avoid style drift in docs/tooling renders.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@content-extract/SKILL.md` at line 14, The documentation line for the "优雅降级"
bullet uses mixed smart quotes around 返回”下一步动作建议”; update that entry so the
phrase uses consistent quote punctuation (e.g., replace the smart double quotes
with Chinese corner quotes 「下一步动作建议」 or ASCII quotes "下一步动作建议") to keep
punctuation consistent in SKILL.md.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@dependency-tracker/SKILL.md`:
- Around line 75-81: The fenced code block that shows the directory tree
(starting with the line containing "```" followed by "data/") lacks a language
tag; update that opening fence to include a language identifier (e.g., change
"```" to "```text") so the block becomes a fenced code block with a language tag
and satisfies markdownlint MD040 while preserving the existing contents like
"data/", "manifest.json", "check-results.json", and "reports/
YYYY-MM-DD-report.md".

In `@github-explorer/SKILL.md`:
- Around line 192-194: Clarify the fallback precedence in SKILL.md by stating
the explicit ordered flow: when fetching non-GitHub pages use web_fetch first,
on web_fetch failure or anti-scraping responses automatically escalate to
content-extract (not browser), and only use browser if explicitly
required/opted-in by the operator; keep the search behavior unchanged
(search-layer default to Deep mode with --intent exploratory and single-source
failures must not block the main flow). Update the sentences referencing
web_fetch, content-extract, browser, and search-layer to reflect this explicit
precedence and ensure the "抓取降级与增强协议" section matches the same order.

In `@mineru-extract/SKILL.md`:
- Around line 88-89: Replace the typographic/curly quotes in the two validation
examples with plain ASCII double quotes: change the JSON check from the
curly-quoted `”ok”: true` to `"ok": true` and change the shell file-check from
`[[ -s “$markdown_path” ]]` to `[[ -s "$markdown_path" ]]`, updating SKILL.md so
both examples use straight quotes for reliable copy-paste and execution.

---

Nitpick comments:
In `@content-extract/SKILL.md`:
- Line 14: The documentation line for the "优雅降级" bullet uses mixed smart quotes
around 返回”下一步动作建议”; update that entry so the phrase uses consistent quote
punctuation (e.g., replace the smart double quotes with Chinese corner quotes
「下一步动作建议」 or ASCII quotes "下一步动作建议") to keep punctuation consistent in SKILL.md.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6f0e51cd-effc-48f7-8345-f7c5409615e6

📥 Commits

Reviewing files that changed from the base of the PR and between 9704c7c and 371b0ed.

📒 Files selected for processing (5)
  • content-extract/SKILL.md
  • dependency-tracker/SKILL.md
  • github-explorer/SKILL.md
  • mineru-extract/SKILL.md
  • search-layer/SKILL.md

Comment on lines 75 to 81
```
data/
├── manifest.json # Full dependency inventory
├── check-results.json # Latest check results
├── check-results.json # Latest check results (see schema below)
└── reports/
└── YYYY-MM-DD-report.md # Generated reports
```
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Add a language tag to the fenced block (markdownlint MD040).

Line 75 opens a fenced block without a language identifier. Please mark it (e.g., text) to satisfy linting and keep formatting consistent.

Suggested patch
-```
+```text
 data/
 ├── manifest.json        # Full dependency inventory
 ├── check-results.json   # Latest check results (see schema below)
 └── reports/
     └── YYYY-MM-DD-report.md  # Generated reports
</details>

<!-- suggestion_start -->

<details>
<summary>📝 Committable suggestion</summary>

> ‼️ **IMPORTANT**
> Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

```suggestion

🧰 Tools
🪛 markdownlint-cli2 (0.22.0)

[warning] 75-75: Fenced code blocks should have a language specified

(MD040, fenced-code-language)

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@dependency-tracker/SKILL.md` around lines 75 - 81, The fenced code block that
shows the directory tree (starting with the line containing "```" followed by
"data/") lacks a language tag; update that opening fence to include a language
identifier (e.g., change "```" to "```text") so the block becomes a fenced code
block with a language tag and satisfies markdownlint MD040 while preserving the
existing contents like "data/", "manifest.json", "check-results.json", and
"reports/ YYYY-MM-DD-report.md".

Comment thread github-explorer/SKILL.md
Comment on lines +192 to +194
- 优先使用 GitHub API(repo 页面)+ `web_fetch`(非 GitHub 页面),browser 作为备选
- **搜索增强**:默认使用 `search-layer` Deep 模式 + `--intent exploratory`,单源失败不阻塞主流程
- **抓取降级**:见上方"抓取降级与增强协议"——web_fetch 失败/反爬时自动升级为 `content-extract`
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Clarify fallback precedence to avoid bypassing the extraction contract.

Line 192 says browser is a backup, but Lines 194 and the extraction-upgrade section define automatic escalation to content-extract on fetch failure. Please make precedence explicit (e.g., web_fetch -> content-extract, browser only if explicitly required) so operators don’t bypass the unified traceable result contract.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@github-explorer/SKILL.md` around lines 192 - 194, Clarify the fallback
precedence in SKILL.md by stating the explicit ordered flow: when fetching
non-GitHub pages use web_fetch first, on web_fetch failure or anti-scraping
responses automatically escalate to content-extract (not browser), and only use
browser if explicitly required/opted-in by the operator; keep the search
behavior unchanged (search-layer default to Deep mode with --intent exploratory
and single-source failures must not block the main flow). Update the sentences
referencing web_fetch, content-extract, browser, and search-layer to reflect
this explicit precedence and ensure the "抓取降级与增强协议" section matches the same
order.

Comment thread mineru-extract/SKILL.md
Comment on lines +88 to +89
1. Check the JSON output has `”ok”: true` — if false, read `errors` for the failure reason
2. Verify `markdown_path` exists and is non-empty: `[[ -s “$markdown_path” ]]`
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Replace smart quotes with ASCII quotes in validation commands/examples.

These two lines currently use typographic quotes ( / ), which can break copy-paste usage in shell/JSON checks.

Suggested doc fix
-1. Check the JSON output has `”ok”: true` — if false, read `errors` for the failure reason
-2. Verify `markdown_path` exists and is non-empty: `[[ -s “$markdown_path” ]]`
+1. Check the JSON output has `"ok": true` — if false, read `errors` for the failure reason
+2. Verify `markdown_path` exists and is non-empty: `[[ -s "$markdown_path" ]]`
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
1. Check the JSON output has `”ok”: true` — if false, read `errors` for the failure reason
2. Verify `markdown_path` exists and is non-empty: `[[ -s $markdown_path ]]`
1. Check the JSON output has `"ok": true` — if false, read `errors` for the failure reason
2. Verify `markdown_path` exists and is non-empty: `[[ -s "$markdown_path" ]]`
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@mineru-extract/SKILL.md` around lines 88 - 89, Replace the typographic/curly
quotes in the two validation examples with plain ASCII double quotes: change the
JSON check from the curly-quoted `”ok”: true` to `"ok": true` and change the
shell file-check from `[[ -s “$markdown_path” ]]` to `[[ -s "$markdown_path"
]]`, updating SKILL.md so both examples use straight quotes for reliable
copy-paste and execution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant