Minor changes to index ID APIs - #96
Merged
Merged
Conversation
CascadingRadium
changed the title
IndexInternalID.Compare
CascadingRadium
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the IndexInternalID helpers in index to improve comparison performance by comparing decoded uint64 values and introduces a Reset API for reusing an existing ID buffer.
Changes:
- Update
IndexInternalID.Compare()to compareuint64values rather than usingbytes.Compare. - Change
IndexInternalID.Value()to return auint64directly (no error return). - Add
IndexInternalID.Reset()to overwrite an existing ID with a new encoded value.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CascadingRadium
requested review from
a team,
Likith101,
Samsonnyyeet,
Thejas-bhat,
capemox,
maneuvertomars and
steveyen
July 2, 2026 07:14
CascadingRadium
changed the title
Likith101
approved these changes
Jul 2, 2026
maneuvertomars
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ValueAPI.SetValuemethod forIndexInternalIDto replace the existing valuewith a new one.