Skip to content

Minor changes to index ID APIs #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CascadingRadium merged 4 commits into from
Jul 2, 2026
Merged

Minor changes to index ID APIs #96

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
24b92b5
perf: §22 replace IndexInternalID.Compare → binary.BigEndian.Uint64
CascadingRadium Jul 1, 2026
182b89b
add a rest method
CascadingRadium Jul 1, 2026
28c482f
revert
CascadingRadium Jul 1, 2026
106ab4c
rename API
CascadingRadium Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions index.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import (
"bytes"
"context"
"encoding/binary"
"fmt"
"reflect"
)

Expand Down Expand Up @@ -204,8 +203,9 @@ func NewIndexInternalID(buf []byte, in uint64) IndexInternalID {
buf = make([]byte, 8)
}
}
binary.BigEndian.PutUint64(buf, in)
return buf
id := IndexInternalID(buf)
id.SetValue(in)
return id
}

// NewIndexInternalIDFrom creates a new IndexInternalID by copying from `other`, reusing `buf` when possible.
Expand All @@ -225,11 +225,13 @@ func (id IndexInternalID) Compare(other IndexInternalID) int {
}

// Value returns the uint64 value encoded in the IndexInternalID.
func (id IndexInternalID) Value() (uint64, error) {
if len(id) != 8 {
return 0, fmt.Errorf("wrong len for IndexInternalID: %q", id)
}
return binary.BigEndian.Uint64(id), nil
func (id IndexInternalID) Value() uint64 {
return binary.BigEndian.Uint64(id)
}
Comment thread
CascadingRadium marked this conversation as resolved.

// SetValue overwrites the encoded uint64 value in the IndexInternalID in place.
func (id IndexInternalID) SetValue(in uint64) {
binary.BigEndian.PutUint64(id, in)
}

type TermFieldDoc struct {
Expand Down
Loading