perf: TermFieldDoc — add NormByte field; targeted Reset writes#97
Open
maneuvertomars wants to merge 1 commit into
Open
perf: TermFieldDoc — add NormByte field; targeted Reset writes#97maneuvertomars wants to merge 1 commit into
maneuvertomars wants to merge 1 commit into
Conversation
Add NormByte uint8 field to carry the raw SmallFloat norm byte from the zapx norm column reader (§20) to the BM25 impact table scorer (§25), avoiding a re-decode at score time. Replace the full-struct duffzero in Reset() with targeted field assignments to preserve the ID and Vectors backing arrays, avoiding one alloc per recycled TermFieldDoc in the recycled TFR path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Companion to blevesearch/zapx#438 and blevesearch/bleve#2383 (the "perf-gar" WAND/MAXSCORE effort).
Adds a
NormByte uint8field toTermFieldDocto carry the raw SmallFloat norm byte from the zapx v18 norm column reader (§20) to the BM25 impact table scorer (§25) in bleve, avoiding a norm re-decode at score time. Also narrowsResetto targeted field writes.Both companion PRs pin this change as a pseudo-version; this needs to land and be tagged before those can move off branch builds.