PYTHON-5846 Drop publish param from _HeartbeatTelemetry, derive from listeners

Author: blink1073

pymongo/_telemetry.py

@@ -351,25 +351,23 @@ class _HeartbeatTelemetry:
     context, then :meth:`succeeded` or :meth:`failed` when the outcome is known.
     """
 
-    __slots__ = ("_address", "_awaited", "_listeners", "_publish", "_start", "_topology_id")
+    __slots__ = ("_address", "_awaited", "_listeners", "_start", "_topology_id")
 
     def __init__(
         self,
         topology_id: ObjectId,
         address: _Address,
         listeners: Optional[_EventListeners],
-        publish: bool,
         awaited: bool,
     ) -> None:
         self._topology_id = topology_id
         self._address = address
         self._listeners = listeners
-        self._publish = publish
         self._awaited = awaited
 
     @property
     def _should_publish(self) -> bool:
-        return self._publish and self._listeners is not None
+        return self._listeners is not None and self._listeners.enabled_for_server_heartbeat
 
     @property
     def _should_log(self) -> bool:

pymongo/asynchronous/monitor.py

@@ -151,7 +151,6 @@ def __init__(
         self._pool = pool
         self._settings = topology_settings
         self._listeners = self._settings._pool_options._event_listeners
-        self._publish = self._listeners is not None and self._listeners.enabled_for_server_heartbeat
         self._cancel_context: Optional[_CancellationContext] = None
         self._conn_id: Optional[int] = None
         self._current_hb: Optional[_HeartbeatTelemetry] = None
@@ -288,9 +287,7 @@ async def _check_once(self) -> ServerDescription:
         awaited = bool(
             self._pool.conns and self._stream and sd.is_server_type_known and sd.topology_version
         )
-        hb = _HeartbeatTelemetry(
-            self._topology._topology_id, address, self._listeners, self._publish, awaited
-        )
+        hb = _HeartbeatTelemetry(self._topology._topology_id, address, self._listeners, awaited)
         self._current_hb = hb
         hb.started()
 

pymongo/synchronous/monitor.py

@@ -151,7 +151,6 @@ def __init__(
         self._pool = pool
         self._settings = topology_settings
         self._listeners = self._settings._pool_options._event_listeners
-        self._publish = self._listeners is not None and self._listeners.enabled_for_server_heartbeat
         self._cancel_context: Optional[_CancellationContext] = None
         self._conn_id: Optional[int] = None
         self._current_hb: Optional[_HeartbeatTelemetry] = None
@@ -286,9 +285,7 @@ def _check_once(self) -> ServerDescription:
         awaited = bool(
             self._pool.conns and self._stream and sd.is_server_type_known and sd.topology_version
         )
-        hb = _HeartbeatTelemetry(
-            self._topology._topology_id, address, self._listeners, self._publish, awaited
-        )
+        hb = _HeartbeatTelemetry(self._topology._topology_id, address, self._listeners, awaited)
         self._current_hb = hb
         hb.started()