Skip to content

Commit a30d380

Browse files
committed
PYTHON-5846 Fix awaited value in heartbeat succeeded APM event
Use response.awaitable (ground truth from wire) rather than self._awaited (pre-computed before response) for ServerHeartbeatSucceededEvent.awaited. Also fix stale method references in _HeartbeatTelemetry docstring.
1 parent 55b21ec commit a30d380

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

pymongo/_telemetry.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -339,7 +339,7 @@ class _HeartbeatTelemetry:
339339
340340
The APM started event is published before connection checkout (no conn_id yet);
341341
the log entry for started is emitted after checkout once the conn_id is known.
342-
Call :meth:`apm_started` first, then :meth:`log_started` inside the checkout
342+
Call :meth:`started` first, then :meth:`emit_started_log` inside the checkout
343343
context, then :meth:`succeeded` or :meth:`failed` when the outcome is known.
344344
"""
345345

@@ -391,7 +391,7 @@ def succeeded(
391391
if self._publish:
392392
assert self._listeners is not None
393393
self._listeners.publish_server_heartbeat_succeeded(
394-
self._address, round_trip_time, response, self._awaited
394+
self._address, round_trip_time, response, response.awaitable
395395
)
396396
if _SDAM_LOGGER.isEnabledFor(logging.DEBUG):
397397
_debug_log(

0 commit comments

Comments
 (0)