Skip to content

Commit a9cb8b2

Browse files
committed
PYTHON-5846 Pass live topology description to ss.succeeded()
1 parent 9fab1db commit a9cb8b2

3 files changed

Lines changed: 6 additions & 4 deletions

File tree

pymongo/_telemetry.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -677,12 +677,14 @@ def failed(self, failure: str, topology_description: Any) -> None:
677677
failure=failure,
678678
)
679679

680-
def succeeded(self, server_host: str, server_port: Optional[int]) -> None:
680+
def succeeded(
681+
self, server_host: str, server_port: Optional[int], topology_description: Any
682+
) -> None:
681683
"""Emit the server selection SUCCEEDED log entry."""
682684
if self._should_log:
683685
self._emit_log(
684686
_ServerSelectionStatusMessage.SUCCEEDED,
685-
self._topology_description,
687+
topology_description,
686688
serverHost=server_host,
687689
serverPort=server_port,
688690
)

pymongo/asynchronous/topology.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -367,7 +367,7 @@ async def select_server(
367367
)
368368
if _csot.get_timeout():
369369
_csot.set_rtt(server.description.min_round_trip_time)
370-
ss.succeeded(server.description.address[0], server.description.address[1])
370+
ss.succeeded(server.description.address[0], server.description.address[1], self.description)
371371
return server
372372

373373
async def select_server_by_address(

pymongo/synchronous/topology.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -367,7 +367,7 @@ def select_server(
367367
)
368368
if _csot.get_timeout():
369369
_csot.set_rtt(server.description.min_round_trip_time)
370-
ss.succeeded(server.description.address[0], server.description.address[1])
370+
ss.succeeded(server.description.address[0], server.description.address[1], self.description)
371371
return server
372372

373373
def select_server_by_address(

0 commit comments

Comments
 (0)