refactor(httputil): generalise range support via ServeCacheHit hooks#359
Merged
Conversation
Add a WithResponseDecorator option and a bytes-served return to ServeCacheHit so endpoints needing custom headers or negotiation can reuse the shared range/conditional machinery instead of reimplementing 206/416/304/412 handling. Refactor the git snapshot and bundle serve paths onto it: both now forward ConditionalOptions to Open and serve via ServeCacheHit, deleting the bespoke range/conditional code and giving bundles range support. Snapshot freshen metadata is injected through the decorator on both full and ranged responses. Drop the now-unused RangeOptions helper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a WithResponseDecorator option and a bytes-served return to
ServeCacheHit so endpoints needing custom headers or negotiation can
reuse the shared range/conditional machinery instead of reimplementing
206/416/304/412 handling.
Refactor the git snapshot and bundle serve paths onto it: both now
forward ConditionalOptions to Open and serve via ServeCacheHit,
deleting the bespoke range/conditional code and giving bundles range
support. Snapshot freshen metadata is injected through the decorator on
both full and ranged responses.
Drop the now-unused RangeOptions helper.