Improve documentation and comments around index narrowing.

Generated with Claude Code

Author: marcdaniels-toast

elasticgraph-graphql/lib/elastic_graph/graphql/datastore_query.rb

@@ -28,8 +28,8 @@ class GraphQL
     # with minimal effort.
     class DatastoreQuery < Support::MemoizableData.define(
       :total_document_count_needed, :aggregations, :logger, :filter_interpreter, :routing_picker,
-      :typename_filter, :index_definitions_by_type_name,
       :index_expression_builder, :default_page_size, :initial_search_index_definitions, :max_page_size,
+      :typename_filter, :index_definitions_by_type_name,
       :client_filters, :internal_filters, :sort, :document_pagination,
       :requested_fields, :request_all_fields, :requested_highlights, :request_all_highlights,
       :individual_docs_needed, :size_multiplier, :monotonic_clock_deadline, :schema_element_names
@@ -140,6 +140,9 @@ def to_datastore_msearch_header_and_body
         @to_datastore_msearch_header_and_body ||= [to_datastore_msearch_header, to_datastore_body]
       end
 
+      # @!attribute [r] initial_search_index_definitions
+      #   The index definitions provided at construction time, before any `__typename`-based narrowing.
+
       # Returns the narrowed set of index definitions to search, based on any `__typename` filter
       # in the client filters. Falls back to `initial_search_index_definitions` when there is no
       # `__typename` filter or no type name mapping is available.

elasticgraph-graphql/lib/elastic_graph/graphql/datastore_query/index_expression_builder.rb

@@ -141,7 +141,7 @@ def +(other)
       # `Query::IndexExpressionBuilder` exists only for use by `Query` and is effectively private.
       private_constant :IndexExpressionBuilder
 
-      # Steep is complaining that it can't find some `Query` but they are not in this file...
+      # Steep can't find implementations of these `DatastoreQuery` methods because they're defined in `datastore_query.rb`, not in this file.
       # @dynamic shard_routing_values, effective_size, merge_with, search_index_expression, narrowed_search_index_definitions, with, to_datastore_msearch_header_and_body
     end
   end

elasticgraph-graphql/lib/elastic_graph/graphql/datastore_query/routing_picker.rb

@@ -53,7 +53,7 @@ def extract_eligible_routing_values(filter_hashes, routing_field_paths)
       # `Query::RoutingPicker` exists only for use by `Query` and is effectively private.
       private_constant :RoutingPicker
 
-      # Steep is complaining that it can't find some `Query` but they are not in this file...
+      # Steep can't find implementations of these `DatastoreQuery` methods because they're defined in `datastore_query.rb`, not in this file.
       # @dynamic shard_routing_values, effective_size, merge_with, search_index_expression, narrowed_search_index_definitions, with, to_datastore_msearch_header_and_body
     end
   end