Rename document_type_stored_in → document_types_stored_in returning Set (#1159)

* Rename document_type_stored_in → document_types_stored_in returning Set

Changes indexed_document_types_by_index_definition_name to accumulate
all indexed document types per index into a Set (was: store only the
first type seen via ||=). This is necessary for correctness with index
inheritance, where multiple concrete types share the same index and all
need to be visible to callers like non_subtypes_in_shared_index.

Renames document_type_stored_in → document_types_stored_in to return
the full Set. Updates the two callers:

- graphql_adapter_builder: .first is safe — this branch is only reached
  for individually-indexed types, which always have exactly one type per
  index (no __typename in the document means no shared index).
- search_response_adapter_builder: use __typename from the document to
  resolve the concrete type directly when present; shared-index types
  carry __typename so field paths in all_highlights resolve to the right
  type. Falls back to .first for individually-indexed types.

Generated with Claude Code

* Make indexed_document_types_by_index_definition_name public

Required by non_subtypes_in_shared_index (on the index inheritance branch),
which needs to enumerate all types sharing an index when deciding whether a
__typename filter is needed on abstract type queries.

Generated with Claude Code

* Address PR review feedback on document_types_stored_in

- Make indexed_document_types_by_index_definition_name private; public
  callers should use document_types_stored_in instead
- Add unit test for multi-type index inheritance case
- Add DistributionChannel type hierarchy to test schema to support
  acceptance test for __typename-aware all_highlights resolution
- Add acceptance test proving all_highlights resolves against the
  concrete type for documents in a shared-index hierarchy
- Update hidden_types_spec to account for new types
- Add distribution_channels and physical_stores index definitions to
  config settings

Generated with Claude Code

* Improve comments on document_types_stored_in and indexed_document_types_by_index_definition_name

Generated with Claude Code

* Improve document_types_stored_in docs

Author: marcdaniels-toast

config/schema/artifacts/data_warehouse.yaml

@@ -38,6 +38,15 @@ tables:
         owner_ids ARRAY<STRING>,
         owner_id STRING
       )
+  distribution_channels:
+    table_schema: |-
+      CREATE TABLE IF NOT EXISTS distribution_channels (
+        id STRING,
+        established_on DATE,
+        active BOOLEAN,
+        name STRING,
+        __typename STRING
+      )
   electrical_parts:
     table_schema: |-
       CREATE TABLE IF NOT EXISTS electrical_parts (
@@ -71,6 +80,13 @@ tables:
         name STRING,
         nationality STRING
       )
+  physical_stores:
+    table_schema: |-
+      CREATE TABLE IF NOT EXISTS physical_stores (
+        id STRING,
+        established_on DATE,
+        active BOOLEAN
+      )
   sponsors:
     table_schema: |-
       CREATE TABLE IF NOT EXISTS sponsors (

config/schema/artifacts/datastore_config.yaml

@@ -1618,6 +1618,35 @@ indices:
       index.number_of_replicas: 1
       index.number_of_shards: 1
       index.max_result_window: 10000
+  distribution_channels:
+    aliases: {}
+    mappings:
+      dynamic: strict
+      properties:
+        id:
+          type: keyword
+        established_on:
+          type: date
+          format: strict_date
+        active:
+          type: boolean
+        name:
+          type: keyword
+        __typename:
+          type: keyword
+        __sources:
+          type: keyword
+        __versions:
+          type: object
+          dynamic: 'false'
+      _size:
+        enabled: true
+    settings:
+      index.mapping.ignore_malformed: false
+      index.mapping.coerce: false
+      index.number_of_replicas: 1
+      index.number_of_shards: 1
+      index.max_result_window: 10000
   electrical_parts:
     aliases: {}
     mappings:
@@ -1733,6 +1762,31 @@ indices:
       index.number_of_replicas: 1
       index.number_of_shards: 1
       index.max_result_window: 10000
+  physical_stores:
+    aliases: {}
+    mappings:
+      dynamic: strict
+      properties:
+        id:
+          type: keyword
+        established_on:
+          type: date
+          format: strict_date
+        active:
+          type: boolean
+        __sources:
+          type: keyword
+        __versions:
+          type: object
+          dynamic: 'false'
+      _size:
+        enabled: true
+    settings:
+      index.mapping.ignore_malformed: false
+      index.mapping.coerce: false
+      index.number_of_replicas: 1
+      index.number_of_shards: 1
+      index.max_result_window: 10000
   sponsors:
     aliases: {}
     mappings:

config/schema/artifacts/json_schemas.yaml

@@ -28,9 +28,12 @@ json_schema_version: 1
         - ElectricalPart
         - Manufacturer
         - MechanicalPart
+        - OnlineStore
         - Person
+        - PhysicalStore
         - Sponsor
         - Team
+        - ThirdPartyWholesale
         - Widget
         - WidgetWorkspace
       id:
@@ -445,6 +448,36 @@ json_schema_version: 1
     oneOf:
     - "$ref": "#/$defs/Person"
     - "$ref": "#/$defs/Company"
+  OnlineStore:
+    type: object
+    properties:
+      id:
+        allOf:
+        - "$ref": "#/$defs/ID"
+        - maxLength: 8191
+      established_on:
+        anyOf:
+        - "$ref": "#/$defs/Date"
+        - type: 'null'
+      active:
+        anyOf:
+        - "$ref": "#/$defs/Boolean"
+        - type: 'null'
+      name:
+        anyOf:
+        - allOf:
+          - "$ref": "#/$defs/String"
+          - maxLength: 8191
+        - type: 'null'
+      __typename:
+        type: string
+        const: OnlineStore
+        default: OnlineStore
+    required:
+    - id
+    - established_on
+    - active
+    - name
   Person:
     type: object
     properties:
@@ -472,6 +505,29 @@ json_schema_version: 1
     - id
     - name
     - nationality
+  PhysicalStore:
+    type: object
+    properties:
+      id:
+        allOf:
+        - "$ref": "#/$defs/ID"
+        - maxLength: 8191
+      established_on:
+        anyOf:
+        - "$ref": "#/$defs/Date"
+        - type: 'null'
+      active:
+        anyOf:
+        - "$ref": "#/$defs/Boolean"
+        - type: 'null'
+      __typename:
+        type: string
+        const: PhysicalStore
+        default: PhysicalStore
+    required:
+    - id
+    - established_on
+    - active
   Player:
     type: object
     properties:
@@ -819,6 +875,24 @@ json_schema_version: 1
     - was_shortened
     - players_nested
     - players_object
+  ThirdPartyWholesale:
+    type: object
+    properties:
+      id:
+        allOf:
+        - "$ref": "#/$defs/ID"
+        - maxLength: 8191
+      active:
+        anyOf:
+        - "$ref": "#/$defs/Boolean"
+        - type: 'null'
+      __typename:
+        type: string
+        const: ThirdPartyWholesale
+        default: ThirdPartyWholesale
+    required:
+    - id
+    - active
   Untyped:
     type:
     - array

config/schema/artifacts/json_schemas_by_version/v1.yaml

@@ -28,9 +28,12 @@ json_schema_version: 1
         - ElectricalPart
         - Manufacturer
         - MechanicalPart
+        - OnlineStore
         - Person
+        - PhysicalStore
         - Sponsor
         - Team
+        - ThirdPartyWholesale
         - Widget
         - WidgetWorkspace
       id:
@@ -565,6 +568,48 @@ json_schema_version: 1
     oneOf:
     - "$ref": "#/$defs/Person"
     - "$ref": "#/$defs/Company"
+  OnlineStore:
+    type: object
+    properties:
+      id:
+        allOf:
+        - "$ref": "#/$defs/ID"
+        - maxLength: 8191
+        ElasticGraph:
+          type: ID!
+          nameInIndex: id
+      established_on:
+        anyOf:
+        - "$ref": "#/$defs/Date"
+        - type: 'null'
+        ElasticGraph:
+          type: Date
+          nameInIndex: established_on
+      active:
+        anyOf:
+        - "$ref": "#/$defs/Boolean"
+        - type: 'null'
+        ElasticGraph:
+          type: Boolean
+          nameInIndex: active
+      name:
+        anyOf:
+        - allOf:
+          - "$ref": "#/$defs/String"
+          - maxLength: 8191
+        - type: 'null'
+        ElasticGraph:
+          type: String
+          nameInIndex: name
+      __typename:
+        type: string
+        const: OnlineStore
+        default: OnlineStore
+    required:
+    - id
+    - established_on
+    - active
+    - name
   Person:
     type: object
     properties:
@@ -601,6 +646,38 @@ json_schema_version: 1
     - id
     - name
     - nationality
+  PhysicalStore:
+    type: object
+    properties:
+      id:
+        allOf:
+        - "$ref": "#/$defs/ID"
+        - maxLength: 8191
+        ElasticGraph:
+          type: ID!
+          nameInIndex: id
+      established_on:
+        anyOf:
+        - "$ref": "#/$defs/Date"
+        - type: 'null'
+        ElasticGraph:
+          type: Date
+          nameInIndex: established_on
+      active:
+        anyOf:
+        - "$ref": "#/$defs/Boolean"
+        - type: 'null'
+        ElasticGraph:
+          type: Boolean
+          nameInIndex: active
+      __typename:
+        type: string
+        const: PhysicalStore
+        default: PhysicalStore
+    required:
+    - id
+    - established_on
+    - active
   Player:
     type: object
     properties:
@@ -1098,6 +1175,30 @@ json_schema_version: 1
     - was_shortened
     - players_nested
     - players_object
+  ThirdPartyWholesale:
+    type: object
+    properties:
+      id:
+        allOf:
+        - "$ref": "#/$defs/ID"
+        - maxLength: 8191
+        ElasticGraph:
+          type: ID!
+          nameInIndex: id
+      active:
+        anyOf:
+        - "$ref": "#/$defs/Boolean"
+        - type: 'null'
+        ElasticGraph:
+          type: Boolean
+          nameInIndex: active
+      __typename:
+        type: string
+        const: ThirdPartyWholesale
+        default: ThirdPartyWholesale
+    required:
+    - id
+    - active
   Untyped:
     type:
     - array