Thread schema definition extension modules through the spec builders

The lazy default now lives in `CommonSpecHelpers` so that
`generate_schema_artifacts` (and `build_datastore_core`, via a new
`schema_definition_extension_modules` option) can use it too. The
`elasticgraph-health_check` and `elasticgraph-query_interceptor` suites —
whose bundles exclude `elasticgraph-json_ingestion` — pass `[]` explicitly.
Spec files that reference the extension constant directly now require it
themselves rather than relying on the deleted probe's load-time side effect.

Author: jwils

elasticgraph-health_check/spec/unit/elastic_graph/health_check/health_checker_spec.rb

@@ -467,6 +467,7 @@ def build_health_checker(health_check:, latest: {}, index_definitions: nil, sche
           clients_by_name: datastore_clients_by_name,
           clock: class_double(::Time, now: now),
           schema_definition: schema_definition,
+          schema_definition_extension_modules: [],
           index_definitions: index_definitions,
           extension_settings: {"health_check" => health_check_settings}.compact
         )

elasticgraph-health_check/spec/unit/envoy_extension_spec.rb

@@ -145,7 +145,7 @@ def process(http_method, url, with_configured_path_segment:, body: nil, cluster_
 
         def build_graphql_for_path(http_path_segment)
           config = {http_path_segment: http_path_segment}.compact
-          schema_artifacts = generate_schema_artifacts do |schema|
+          schema_artifacts = generate_schema_artifacts(extension_modules: []) do |schema|
             schema.register_graphql_extension(EnvoyExtension, defined_at: "elastic_graph/health_check/envoy_extension", **config)
             schema.object_type "Widget" do |t|
               t.field "id", "ID"

elasticgraph-json_ingestion/spec/unit/elastic_graph/json_ingestion/schema_definition/indexing/json_schema_with_metadata_spec.rb

@@ -6,6 +6,7 @@
 #
 # frozen_string_literal: true
 
+require "elastic_graph/json_ingestion/schema_definition/api_extension"
 require "elastic_graph/json_ingestion/schema_definition/indexing/json_schema_with_metadata"
 require "elastic_graph/spec_support/schema_definition_helpers"
 

elasticgraph-json_ingestion/spec/unit/elastic_graph/json_ingestion/schema_definition/json_schema_field_metadata_spec.rb

@@ -6,6 +6,7 @@
 #
 # frozen_string_literal: true
 
+require "elastic_graph/json_ingestion/schema_definition/api_extension"
 require "elastic_graph/json_ingestion/schema_definition/indexing/json_schema_field_metadata"
 require "elastic_graph/spec_support/schema_definition_helpers"
 

elasticgraph-json_ingestion/spec/unit/elastic_graph/json_ingestion/schema_definition/schema_elements/scalar_type_extension_spec.rb

@@ -8,6 +8,7 @@
 
 require "elastic_graph/constants"
 require "elastic_graph/errors"
+require "elastic_graph/json_ingestion/schema_definition/api_extension"
 require "elastic_graph/json_ingestion/schema_definition/schema_elements/scalar_type_extension"
 require "elastic_graph/spec_support/schema_definition_helpers"
 

elasticgraph-query_interceptor/spec/unit/elastic_graph/query_interceptor/graphql_extension_spec.rb

@@ -170,7 +170,7 @@ def expect_configured_interceptors(graphql)
       end
 
       def generate_schema_artifacts
-        super do |schema|
+        super(extension_modules: []) do |schema|
           yield schema
 
           # Ensure there's at least one indexed type defined to avoid GraphQL validation errors.

elasticgraph-schema_definition/spec/unit/elastic_graph/schema_definition/runtime_metadata/runtime_metadata_support.rb

@@ -6,7 +6,6 @@
 #
 # frozen_string_literal: true
 
-require "elastic_graph/json_ingestion/schema_definition/api_extension"
 require "elastic_graph/spec_support/schema_definition_helpers"
 require "elastic_graph/spec_support/runtime_metadata_support"
 

spec_support/lib/elastic_graph/spec_support/builds_datastore_core.rb

@@ -29,6 +29,7 @@ def build_datastore_core(
       clusters: nil,
       schema_artifacts_directory: nil,
       schema_artifacts: nil,
+      schema_definition_extension_modules: nil,
       datastore_backend: nil,
       reload_schema_artifacts: false,
       **config_overrides,
@@ -59,6 +60,7 @@ def build_datastore_core(
             schema_element_name_overrides: schema_element_name_overrides,
             derived_type_name_formats: derived_type_name_formats,
             enum_value_overrides_by_type: enum_value_overrides_by_type,
+            extension_modules: schema_definition_extension_modules || default_schema_definition_extension_modules,
             reload_schema_artifacts: reload_schema_artifacts,
             &schema_definition
           )

spec_support/lib/elastic_graph/spec_support/schema_definition_helpers.rb

@@ -35,12 +35,7 @@ def define_schema_with_schema_elements(schema_elements, extension_modules: defau
     )
   end
 
-  # The require is performed lazily (only when a spec relies on the default) so that this file can be
-  # loaded in spec bundles that do not include the optional `elasticgraph-json_ingestion` gem. Suites in
-  # such bundles must pass `extension_modules:` explicitly; if one relies on the default it will get a
-  # clear `LoadError` here rather than silently building schema artifacts without JSON schemas.
-  def default_schema_definition_extension_modules
-    require "elastic_graph/json_ingestion/schema_definition/api_extension"
-    [::ElasticGraph::JSONIngestion::SchemaDefinition::APIExtension]
-  end
+  # `default_schema_definition_extension_modules` is provided by `CommonSpecHelpers`, which performs
+  # the `elasticgraph-json_ingestion` require lazily so this file can be loaded in spec bundles that
+  # do not include that optional gem.
 end

spec_support/spec_helper.rb

@@ -356,14 +356,23 @@ def without_vcr
     end
     # :nocov:
 
+    # The require is performed lazily (only when a spec relies on the default) so that this can be used
+    # from spec bundles that do not include the optional `elasticgraph-json_ingestion` gem. Suites in
+    # such bundles must pass `extension_modules:` explicitly; if one relies on the default it will get a
+    # clear `LoadError` here rather than silently building schema artifacts without JSON schemas.
+    def default_schema_definition_extension_modules
+      require "elastic_graph/json_ingestion/schema_definition/api_extension"
+      [::ElasticGraph::JSONIngestion::SchemaDefinition::APIExtension]
+    end
+
     def generate_schema_artifacts(
       schema_element_name_form: :snake_case,
       schema_element_name_overrides: {},
       derived_type_name_formats: {},
       enum_value_overrides_by_type: {},
+      extension_modules: default_schema_definition_extension_modules,
       reload_schema_artifacts: false
     )
-      require "elastic_graph/json_ingestion/schema_definition/api_extension"
       require "elastic_graph/schema_definition/test_support"
       require "stringio"
 
@@ -373,7 +382,7 @@ def generate_schema_artifacts(
         schema_element_name_overrides: schema_element_name_overrides,
         derived_type_name_formats: derived_type_name_formats,
         enum_value_overrides_by_type: enum_value_overrides_by_type,
-        extension_modules: [::ElasticGraph::JSONIngestion::SchemaDefinition::APIExtension],
+        extension_modules: extension_modules,
         reload_schema_artifacts: reload_schema_artifacts,
         output: output
       ) do |schema|