Add schema definition extension plumbing

Author: jwils

Rakefile

@@ -46,7 +46,6 @@ end
 
 configure_local_rake_tasks = ->(tasks) do
   tasks.schema_element_name_form = :snake_case
-  tasks.enforce_json_schema_version = false
   tasks.index_document_sizes = true
   tasks.env_port_mapping = {test: test_port}
   tasks.output = schema_def_output

config/schema.rb

@@ -8,6 +8,7 @@
 
 ElasticGraph.define_schema do |schema|
   schema.json_schema_version 1
+  schema.enforce_json_schema_version false
 end
 
 # Note: anytime you add a file to load here, you'll also have to update the list here:

config/site/Rakefile

@@ -448,7 +448,6 @@ module ElasticGraph
               namespace schema_name do
                 ::ElasticGraph::Local::RakeTasks.new(local_config_yaml: settings_file, path_to_schema: schema_file) do |tasks|
                   tasks.opensearch_versions = []
-                  tasks.enforce_json_schema_version = false
                 end
 
                 task validate: ["schema_artifacts:dump"] do

config/site/support/doctest_helper.rb

@@ -82,7 +82,6 @@ module ElasticGraph
         artifacts_manager = @api.factory.new_schema_artifact_manager(
           schema_definition_results: @api.results,
           schema_artifacts_directory: "#{@tmp_dir}/schema_artifacts",
-          enforce_json_schema_version: true,
           output: ::StringIO.new
         )
 

elasticgraph-admin/spec/integration/elastic_graph/admin/index_definition_configurator/for_index_template_spec.rb

@@ -167,7 +167,6 @@ def fetch_artifact_configuration(schema_artifacts, index_def_name)
               factory.new_schema_artifact_manager(
                 schema_definition_results: schema_def_results,
                 schema_artifacts_directory: Dir.pwd,
-                enforce_json_schema_version: true,
                 output: output_io
               ).dump_artifacts
 

elasticgraph-apollo/README.md

@@ -64,15 +64,14 @@ index 2943335..26633c3 100644
  require "elastic_graph/local/rake_tasks"
  require "elastic_graph/query_registry/rake_tasks"
  require "rspec/core/rake_task"
-@@ -12,6 +13,8 @@ ElasticGraph::Local::RakeTasks.new(
+@@ -12,5 +13,7 @@ ElasticGraph::Local::RakeTasks.new(
    local_config_yaml: settings_file,
    path_to_schema: "#{project_root}/config/schema.rb"
  ) do |tasks|
 +  tasks.schema_definition_extension_modules = [ElasticGraph::Apollo::SchemaDefinition::APIExtension]
 +
-   # Set this to true once you're beyond the prototyping stage.
-   tasks.enforce_json_schema_version = false
-
+   # Determines casing of field names. Can be either `:camelCase` or `:snake_case`.
+   tasks.schema_element_name_form = :camelCase
 ```
 
 That's it!
@@ -94,11 +93,16 @@ diff --git a/config/schema.rb b/config/schema.rb
 index 015c5fa..362cdcb 100644
 --- a/config/schema.rb
 +++ b/config/schema.rb
-@@ -4,6 +4,8 @@ ElasticGraph.define_schema do |schema|
+@@ -4,7 +4,9 @@ ElasticGraph.define_schema do |schema|
    # ElasticGraph will tell you when you need to bump this.
    schema.json_schema_version 1
-
+-
++
 +  schema.target_apollo_federation_version "2.3"
++
+   # Set this to true once you're beyond the prototyping stage.
+   schema.enforce_json_schema_version false
+-
 +
    # This registers the elasticgraph-query_registry extension, which can be used to reject queries that
    # clients have not registered (and to reject queries that differ from what a client has registered).

elasticgraph-apollo/apollo_tests_implementation/Rakefile

@@ -17,6 +17,5 @@ ElasticGraph::SchemaDefinition::RakeTasks.new(
   index_document_sizes: false,
   path_to_schema: project_root / "config/products_schema.rb",
   schema_artifacts_directory: project_root / "config/schema/artifacts",
-  extension_modules: [ElasticGraph::Apollo::SchemaDefinition::APIExtension],
-  enforce_json_schema_version: false
+  extension_modules: [ElasticGraph::Apollo::SchemaDefinition::APIExtension]
 )

elasticgraph-apollo/apollo_tests_implementation/config/products_schema.rb

@@ -18,6 +18,7 @@ module ApolloTestImpl
   # https://github.com/apollographql/apollo-federation-subgraph-compatibility/blob/2.0.0/COMPATIBILITY.md#products-schema-to-be-implemented-by-library-maintainers
   ElasticGraph.define_schema do |schema|
     schema.json_schema_version 1
+    schema.enforce_json_schema_version false
     schema.target_apollo_federation_version(federation_version) if federation_version
 
     unless federation_version == "2.0"

elasticgraph-graphql/spec/acceptance/schema_evolution_spec.rb

@@ -68,7 +68,6 @@ def dump_schema_artifacts(json_schema_version:, team_extras: "")
           index_document_sizes: true,
           path_to_schema: path_to_schema,
           schema_artifacts_directory: "config/schema/artifacts",
-          enforce_json_schema_version: true,
           output: output
         )
       end

elasticgraph-indexer/spec/acceptance/schema_evolution_spec.rb

@@ -404,7 +404,6 @@ def dump_artifacts
           index_document_sizes: true,
           path_to_schema: path_to_schema,
           schema_artifacts_directory: "config/schema/artifacts",
-          enforce_json_schema_version: true,
           output: output
         )
       end