Make schema definition extension modules fully opt-in in specs

Nothing needs the defaulting anymore. The shared spec helpers no longer
apply the JSON ingestion extension to schema definitions; instead, each
place that genuinely needs JSON schemas opts in explicitly:

- `generate_schema_artifacts` includes the extension only when loading
  the repository's main test schema (`config/schema.rb`), which uses the
  JSON ingestion schema definition DSL.
- `build_indexer` includes the extension when it generates artifacts
  itself, since the indexer can only ingest JSON events today. The
  require is lazy so bundles without `elasticgraph-json_ingestion` can
  still build an indexer from an externally built `datastore_core:`.
- Specs that index documents with inline schemas (and so need JSON
  schema validation) pass the extension at their build call sites.
- Vestigial `t.json_schema` calls in unit specs that never index are
  removed, along with a `JsonSafeLong` placeholder assertion that
  duplicated coverage now living in elasticgraph-json_ingestion.

Author: jwils

elasticgraph-datastore_core/spec/integration/elastic_graph/datastore_core/index_definition/rollover_index_template_spec.rb

@@ -8,6 +8,7 @@
 
 require "elastic_graph/constants"
 require "elastic_graph/datastore_core/index_definition"
+require "elastic_graph/json_ingestion/schema_definition/api_extension"
 require "elastic_graph/support/hash_util"
 require "stringio"
 require_relative "implementation_shared_examples"
@@ -16,6 +17,12 @@ module ElasticGraph
   class DatastoreCore
     module IndexDefinition
       RSpec.describe RolloverIndexTemplate, :uses_datastore, :builds_indexer do
+        # Documents indexed by these specs are validated against the JSON schemas, so the schemas
+        # defined in this file all include the JSON ingestion schema definition extension.
+        def build_datastore_core(**options, &block)
+          super(schema_definition_extension_modules: [JSONIngestion::SchemaDefinition::APIExtension], **options, &block)
+        end
+
         # Use different index names than any other tests use, because most tests expect a specific index
         # configuration (based on `config/schema.graphql`) and we do not want to mess with it here.
         let(:index_prefix) { unique_index_name }

elasticgraph-graphql/spec/acceptance/elasticgraph_graphql_acceptance_support.rb

@@ -7,6 +7,7 @@
 # frozen_string_literal: true
 
 require "elastic_graph/graphql/datastore_search_router"
+require "elastic_graph/json_ingestion/schema_definition/api_extension"
 require "elastic_graph/schema_definition/schema_elements/type_namer"
 require "elastic_graph/spec_support/builds_admin"
 require "graphql"
@@ -91,6 +92,9 @@ def self.with_both_casing_forms(&block)
             schema_element_name_form: :camelCase,
             derived_type_name_formats: derived_type_name_formats,
             enum_value_overrides_by_type: enum_value_overrides_by_type,
+            # The camelCase schema definition below is derived from the repository's main test schema,
+            # which uses the JSON ingestion schema definition DSL, so it requires this extension.
+            schema_definition_extension_modules: [JSONIngestion::SchemaDefinition::APIExtension],
             schema_definition: ->(schema) do
               # standard:disable Security/Eval -- it's ok here in a test.
               schema.as_active_instance { eval(camel_case_schema_def) }

elasticgraph-graphql/spec/integration/elastic_graph/graphql/datastore_query/misc_spec.rb

@@ -9,6 +9,7 @@
 require_relative "datastore_query_integration_support"
 require "elastic_graph/errors"
 require "elastic_graph/graphql/datastore_search_router"
+require "elastic_graph/json_ingestion/schema_definition/api_extension"
 
 module ElasticGraph
   class GraphQL
@@ -85,7 +86,7 @@ def msearch(body:, **args, &block)
 
       context "when the indexed type has nested `default_sort_fields`" do
         let(:graphql) do
-          build_graphql(schema_definition: lambda do |schema|
+          build_graphql(schema_definition_extension_modules: [JSONIngestion::SchemaDefinition::APIExtension], schema_definition: lambda do |schema|
             schema.object_type "Money" do |t|
               t.field "currency", "String!"
               t.field "amount_cents", "Int!"

elasticgraph-graphql/spec/integration/elastic_graph/graphql/resolvers/nested_relationships_spec.rb

@@ -7,6 +7,7 @@
 # frozen_string_literal: true
 
 require "elastic_graph/graphql/resolvers/nested_relationships"
+require "elastic_graph/json_ingestion/schema_definition/api_extension"
 
 module ElasticGraph
   class GraphQL
@@ -16,7 +17,7 @@ module Resolvers
         # is implemented via a filter on `id` (the search routing field)
         context "when the field being resolved is a relay connection field", :expect_search_routing do
           let(:graphql) do
-            build_graphql(schema_definition: lambda do |schema|
+            build_graphql(schema_definition_extension_modules: [JSONIngestion::SchemaDefinition::APIExtension], schema_definition: lambda do |schema|
               schema.object_type "Component" do |t|
                 t.field "id", "ID!"
                 t.field "name", "String!"
@@ -62,7 +63,7 @@ module Resolvers
 
         describe "a relates_to_many/relates_to_one bidirectional relationship with an array foreign key from the one to the many" do
           let(:graphql) do
-            build_graphql(schema_definition: lambda do |schema|
+            build_graphql(schema_definition_extension_modules: [JSONIngestion::SchemaDefinition::APIExtension], schema_definition: lambda do |schema|
               schema.object_type "Money" do |t|
                 t.field "currency", "String!"
                 t.field "amount_cents", "Int"
@@ -241,7 +242,7 @@ module Resolvers
 
         describe "a relates_to_many/relates_to_one bidirectional relationship with a scalar foreign key from the many to the one" do
           let(:graphql) do
-            build_graphql(schema_definition: lambda do |schema|
+            build_graphql(schema_definition_extension_modules: [JSONIngestion::SchemaDefinition::APIExtension], schema_definition: lambda do |schema|
               schema.object_type "ElectricalPart" do |t|
                 t.field "id", "ID!"
                 t.field "name", "String!"
@@ -381,7 +382,7 @@ module Resolvers
 
         describe "a relates_to_many/relates_to_many bidirectional relationship with an array foreign key from a many to a many" do
           let(:graphql) do
-            build_graphql(schema_definition: lambda do |schema|
+            build_graphql(schema_definition_extension_modules: [JSONIngestion::SchemaDefinition::APIExtension], schema_definition: lambda do |schema|
               schema.object_type "Component" do |t|
                 t.field "id", "ID!"
                 t.field "name", "String!"
@@ -573,7 +574,7 @@ module Resolvers
 
         describe "a relates_to_one/relates_to_one bidirectional relationship with a scalar foreign key from a one to a one" do
           let(:graphql) do
-            build_graphql(schema_definition: lambda do |schema|
+            build_graphql(schema_definition_extension_modules: [JSONIngestion::SchemaDefinition::APIExtension], schema_definition: lambda do |schema|
               schema.object_type "Manufacturer" do |t|
                 t.field "id", "ID!"
                 t.field "name", "String"

elasticgraph-graphql/spec/unit/elastic_graph/graphql/query_executor_spec.rb

@@ -447,7 +447,6 @@ def resolve(field:, object:, args:, context:)
 
               schema.scalar_type "Operands" do |t|
                 t.mapping type: nil
-                t.json_schema type: "null"
               end
 
               schema.object_type "Widget" do |t|

elasticgraph-graphql/spec/unit/elastic_graph/graphql/resolvers/get_record_field_value_spec.rb

@@ -19,7 +19,6 @@ module Resolvers
           self.schema_artifacts = generate_schema_artifacts do |schema|
             schema.scalar_type "MyInt" do |t|
               t.mapping type: "integer"
-              t.json_schema type: "integer"
             end
 
             schema.object_type "PersonIdentifiers" do |t|

elasticgraph-graphql/spec/unit/elastic_graph/graphql/scalar_coercion_adapters/no_op_spec.rb

@@ -14,7 +14,6 @@ module ScalarCoercionAdapters
       RSpec.describe "NoOp" do
         include_context("scalar coercion adapter support", "SomeCustomScalar", schema_definition: ->(schema) do
           schema.scalar_type "SomeCustomScalar" do |t|
-            t.json_schema type: "null"
             t.mapping type: nil
           end
 

elasticgraph-graphql/spec/unit/elastic_graph/graphql/schema/type_spec.rb

@@ -955,7 +955,6 @@ def search_index_definitions_from(type_name: "TheType")
             schema = define_schema do |s|
               s.scalar_type "CustomScalar" do |t|
                 t.mapping type: "keyword"
-                t.json_schema type: "string"
               end
             end
 
@@ -967,7 +966,6 @@ def search_index_definitions_from(type_name: "TheType")
             schema = define_schema do |s|
               s.scalar_type "CustomScalar" do |t|
                 t.mapping type: "keyword"
-                t.json_schema type: "string"
                 t.grouping_missing_value_placeholder "MISSING"
               end
             end
@@ -980,7 +978,6 @@ def search_index_definitions_from(type_name: "TheType")
             schema = define_schema do |s|
               s.scalar_type "CustomScalar" do |t|
                 t.mapping type: "keyword"
-                t.json_schema type: "string"
                 t.grouping_missing_value_placeholder nil
               end
             end
@@ -1007,7 +1004,6 @@ def search_index_definitions_from(type_name: "TheType")
                 t.field "name", "String"
                 t.field "count", "Int"
                 t.field "price", "Float"
-                t.field "big_number", "JsonSafeLong"
                 t.index "things"
               end
             end
@@ -1016,7 +1012,6 @@ def search_index_definitions_from(type_name: "TheType")
             expect(schema.type_named("String").grouping_missing_value_placeholder).to eq MISSING_STRING_PLACEHOLDER_VALUE
             expect(schema.type_named("Int").grouping_missing_value_placeholder).to eq MISSING_NUMERIC_PLACEHOLDER
             expect(schema.type_named("Float").grouping_missing_value_placeholder).to eq MISSING_NUMERIC_PLACEHOLDER
-            expect(schema.type_named("JsonSafeLong").grouping_missing_value_placeholder).to eq MISSING_NUMERIC_PLACEHOLDER
           end
 
           it "returns nil for object types" do

elasticgraph-graphql/spec/unit/elastic_graph/graphql/schema_spec.rb

@@ -16,7 +16,6 @@ class GraphQL
         define_schema do |schema|
           schema.scalar_type "_FieldSet" do |t|
             t.mapping type: "keyword"
-            t.json_schema type: "string"
           end
 
           schema.object_type "Widget" do |t|

elasticgraph-indexer/spec/support/multiple_version_support.rb

@@ -6,6 +6,7 @@
 #
 # frozen_string_literal: true
 
+require "elastic_graph/json_ingestion/schema_definition/api_extension"
 require "elastic_graph/spec_support/schema_definition_helpers"
 
 module ElasticGraph
@@ -15,7 +16,12 @@ class Indexer
 
       def build_indexer_with_multiple_schema_versions(schema_versions:)
         results_by_version = schema_versions.to_h do |json_schema_version, prior_def|
-          results = define_schema(schema_element_name_form: :snake_case, json_schema_version: json_schema_version, &prior_def)
+          results = define_schema(
+            schema_element_name_form: :snake_case,
+            json_schema_version: json_schema_version,
+            extension_modules: [JSONIngestion::SchemaDefinition::APIExtension],
+            &prior_def
+          )
           [json_schema_version, results]
         end