Skip to content

Commit 9dc09e9

Browse files
committed
Fix query details tracker keyword initialization
1 parent f3818af commit 9dc09e9

2 files changed

Lines changed: 17 additions & 1 deletion

File tree

elasticgraph-graphql/lib/elastic_graph/graphql/query_details_tracker.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@ class QueryDetailsTracker < Struct.new(
1818
:datastore_query_client_duration_ms,
1919
:queried_shard_count,
2020
:extension_data,
21-
:mutex
21+
:mutex,
22+
keyword_init: true
2223
)
2324
def self.empty
2425
new(

elasticgraph-graphql/spec/unit/elastic_graph/graphql/query_details_tracker_spec.rb

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,21 @@
1111
module ElasticGraph
1212
class GraphQL
1313
RSpec.describe QueryDetailsTracker do
14+
describe ".empty" do
15+
it "initializes all tracker fields" do
16+
tracker = QueryDetailsTracker.empty
17+
18+
expect(tracker.shard_routing_values).to eq ::Set.new
19+
expect(tracker.search_index_expressions).to eq ::Set.new
20+
expect(tracker.query_counts_per_datastore_request).to eq []
21+
expect(tracker.datastore_query_server_duration_ms).to eq 0
22+
expect(tracker.datastore_query_client_duration_ms).to eq 0
23+
expect(tracker.queried_shard_count).to eq 0
24+
expect(tracker.extension_data).to eq({})
25+
expect(tracker.mutex).to be_a ::Thread::Mutex
26+
end
27+
end
28+
1429
describe "#[]=" do
1530
let(:tracker) { QueryDetailsTracker.empty }
1631

0 commit comments

Comments
 (0)