Commit bbfaa36
authored
Fix nodes returning empty when only
* Fix nodes returning empty when only __typename is requested
When a query selects only `__typename` under `nodes` or `edges { node }`,
`requested_fields` ends up empty (because `__typename` is a dynamic field
and is stripped before populating `requested_fields`). This left
`individual_docs_needed: false`, causing `size: 0` in the datastore query
and returning no documents despite `total_edge_count > 0`.
Fix by additionally setting `individual_docs_needed: true` whenever
`nodes` or `edges.node` is selected at all — the client selecting that
part of the query is itself the signal that individual documents are needed.
Fixes #1055
Generated with Claude Code
* Add unit tests for individual_docs_needed when only __typename is requested
Covers the fix from the previous commit at the unit level, as requested
in code review.
Generated with Claude Code__typename is requested (#1170)1 parent fff64e7 commit bbfaa36
3 files changed
Lines changed: 69 additions & 1 deletion
File tree
- elasticgraph-graphql
- lib/elastic_graph/graphql/query_adapter
- spec
- acceptance
- unit/elastic_graph/graphql/query_adapter
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | | - | |
| 58 | + | |
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
913 | 913 | | |
914 | 914 | | |
915 | 915 | | |
| 916 | + | |
| 917 | + | |
| 918 | + | |
| 919 | + | |
| 920 | + | |
| 921 | + | |
| 922 | + | |
| 923 | + | |
| 924 | + | |
| 925 | + | |
| 926 | + | |
| 927 | + | |
| 928 | + | |
| 929 | + | |
| 930 | + | |
| 931 | + | |
| 932 | + | |
| 933 | + | |
| 934 | + | |
| 935 | + | |
| 936 | + | |
| 937 | + | |
| 938 | + | |
| 939 | + | |
| 940 | + | |
| 941 | + | |
| 942 | + | |
| 943 | + | |
| 944 | + | |
| 945 | + | |
| 946 | + | |
| 947 | + | |
| 948 | + | |
| 949 | + | |
| 950 | + | |
| 951 | + | |
916 | 952 | | |
917 | 953 | | |
918 | 954 | | |
| |||
Lines changed: 32 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
669 | 669 | | |
670 | 670 | | |
671 | 671 | | |
| 672 | + | |
| 673 | + | |
| 674 | + | |
| 675 | + | |
| 676 | + | |
| 677 | + | |
| 678 | + | |
| 679 | + | |
| 680 | + | |
| 681 | + | |
| 682 | + | |
| 683 | + | |
| 684 | + | |
| 685 | + | |
| 686 | + | |
| 687 | + | |
| 688 | + | |
| 689 | + | |
| 690 | + | |
| 691 | + | |
| 692 | + | |
| 693 | + | |
| 694 | + | |
| 695 | + | |
| 696 | + | |
| 697 | + | |
| 698 | + | |
| 699 | + | |
| 700 | + | |
| 701 | + | |
| 702 | + | |
| 703 | + | |
672 | 704 | | |
673 | 705 | | |
674 | 706 | | |
| |||
0 commit comments