Fix/id field non nullable json schema (#1118)

* Enforce non-nullability in required ID field

* Fix broken Goose documentation link

The Goose docs moved from block.github.io/goose to goose-docs.ai,
causing a 404 in the HTML-Proofer CI check.

* remove unnecessary change

* remove non-nullable from ID field to force test coverage

* update schema rtifacts

Author: rossroberts-toast

config/schema/artifacts/schema.graphql

@@ -10318,7 +10318,7 @@ type Team {
   forbes_valuation_moneys_object: [Money!]!
   forbes_valuations: [JsonSafeLong!]!
   formed_on: Date
-  id: ID!
+  id: ID
   league: String
   nested_fields: TeamNestedFields
   nested_fields2: TeamNestedFields

config/schema/artifacts_with_apollo/schema.graphql

@@ -10641,7 +10641,7 @@ type Team @key(fields: "id") {
   forbes_valuation_moneys_object: [Money!]!
   forbes_valuations: [JsonSafeLong!]!
   formed_on: Date
-  id: ID!
+  id: ID
   league: String
   nested_fields: TeamNestedFields
   nested_fields2: TeamNestedFields

config/schema/teams.rb

@@ -39,7 +39,7 @@
 
   schema.object_type "Team" do |t|
     t.root_query_fields plural: "teams"
-    t.field "id", "ID!"
+    t.field "id", "ID"
     t.field "league", "String"
     t.field "country_code", "ID!"
     t.field "formed_on", "Date"

elasticgraph-schema_definition/lib/elastic_graph/schema_definition/indexing/index.rb

@@ -63,7 +63,9 @@ def initialize(name, settings, schema_def_state, indexed_type)
             # By using it here, it will cause queries to pass a `routing` parameter when
             # searching with id filtering on an index that does not use custom shard routing, giving
             # us a nice efficiency boost.
-            self.routing_field_path = public_field_path("id", explanation: "indexed types must have an `id` field")
+            id_field_path = public_field_path("id", explanation: "indexed types must have an `id` field")
+            self.routing_field_path = id_field_path
+            id_field_path.last_part.json_schema nullable: false
           end
 
           yield self if block_given?

elasticgraph-schema_definition/spec/unit/elastic_graph/schema_definition/json_schema_spec.rb

@@ -1140,6 +1140,29 @@ def have_json_schema_like(type_name, *args, **kwargs)
         })
       end
 
+      it "makes the `id` field non-nullable in JSON schema even when declared as a nullable `ID` in the GraphQL schema" do
+        json_schema = dump_schema do |s|
+          s.object_type "Widget" do |t|
+            t.field "id", "ID"
+            t.field "name", "String"
+            t.index "widgets"
+          end
+        end
+
+        expect(json_schema).to have_json_schema_like("Widget", {
+          "type" => "object",
+          "properties" => {
+            "id" => json_schema_ref("ID!"),
+            "name" => json_schema_ref("String")
+          },
+          "required" => %w[id name]
+        }).which_matches(
+          {"id" => "abc", "name" => "thing"}
+        ).and_fails_to_match(
+          {"id" => nil, "name" => "thing"}
+        )
+      end
+
       context "on an indexed type with a rollover index" do
         it "makes the JSON schema for a rollover index timestamp field on the indexed type non-nullable since a target index cannot be chosen without it" do
           json_schema = dump_schema do |s|