Commit de462ca
committed
Remove remaining JSON schema usage from schema definition specs
As noted on #1224, mentions of JSON schema in
`elasticgraph-schema_definition/spec` should approach zero now that the JSON
schema logic lives in `elasticgraph-json_ingestion`:
- The graphql_schema, datastore_config, and runtime_metadata spec supports
now run schemas without any extension modules, and the `json_schema` calls
that existed only to satisfy the extension's scalar validation are gone.
- The scalar `json_schema` requirement test (duplicated by the json_ingestion
suite) is deleted, and the `long`/`unsigned_long` placeholder-inference
tests that depend on JSON schema bounds moved to the json_ingestion suite
(along with the built-in-scalar placeholder map, which differs with the
extension loaded).
- The reserved-type-name test now exercises the core `reserved_type_names`
mechanism directly; the `ElasticGraphEventEnvelope` reservation is already
covered by the json_ingestion suite.
- `rake_tasks_spec` runs its synthetic schemas without the extension and no
longer asserts on JSON schema artifacts (covered by json_ingestion's
integration spec). A new short-diff test keeps `truncate_diff` fully
covered. The tests that evaluate the repo's own `config/schema.rb` still
load the extension, since that schema is a JSON ingestion application.
The remaining mentions are the `define_schema` test-support seam (which
exists for optional ingestion extensions) and JSON-the-format documentation
text.1 parent df526fc commit de462ca
16 files changed
Lines changed: 209 additions & 253 deletions
File tree
- elasticgraph-json_ingestion/spec/unit/elastic_graph/json_ingestion/schema_definition
- schema_elements
- elasticgraph-schema_definition/spec
- integration/elastic_graph/schema_definition
- unit/elastic_graph/schema_definition
- datastore_config
- index_mappings
- graphql_schema
- runtime_metadata
- object_types_by_name
Lines changed: 21 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3151 | 3151 | | |
3152 | 3152 | | |
3153 | 3153 | | |
| 3154 | + | |
| 3155 | + | |
| 3156 | + | |
| 3157 | + | |
| 3158 | + | |
| 3159 | + | |
| 3160 | + | |
| 3161 | + | |
| 3162 | + | |
| 3163 | + | |
| 3164 | + | |
| 3165 | + | |
| 3166 | + | |
| 3167 | + | |
| 3168 | + | |
| 3169 | + | |
| 3170 | + | |
| 3171 | + | |
| 3172 | + | |
| 3173 | + | |
| 3174 | + | |
3154 | 3175 | | |
3155 | 3176 | | |
3156 | 3177 | | |
| |||
Lines changed: 116 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
83 | 83 | | |
84 | 84 | | |
85 | 85 | | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
86 | 201 | | |
87 | 202 | | |
88 | 203 | | |
89 | 204 | | |
90 | 205 | | |
91 | | - | |
| 206 | + | |
92 | 207 | | |
93 | 208 | | |
94 | 209 | | |
| |||
0 commit comments