Add myron-polish skill for pre-review code polishing#1147
Merged
Conversation
Distills the patterns Myron Marston applies when reviewing merged PRs (naming at the caller's level of abstraction, respond_to? as a code smell, wrapper-class DI pattern, load-bearing tests, RBS/YARD hygiene, etc.) into an edit-first skill. Invoked as /myron-polish, the skill walks the current branch's diff against main and applies fixes directly rather than producing review comments. It loops — re-scan, apply edits, run script/lint --fix / script/spellcheck -w / script/type_check / script/run_gem_specs — until a full iteration makes zero edits and every verification command passes. Capped at 8 iterations. Source material: Myron's review bodies and inline comments on merged PRs #974, #973, #1067, #1066, #1108, #1120, #1131, #1134, #1144, #1107. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jwils
requested review from
BrianSigafoos-SQ,
ayousufi,
bsorbo,
jwondrusch and
myronmarston
as code owners
myronmarston
approved these changes
Apr 23, 2026
Collaborator
myronmarston
left a comment
myronmarston
left a comment
There was a problem hiding this comment.
I LOL'd a bit at this. Feels funny to call me out by name in the skill like this. I'll be curious to here how well it works in practice when you use it :).
I also think some of the things here are overly specific--we'll see if those situations arise again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.claude/skills/myron-polish/SKILL.mdthat distills Myron's review preferences on this repo into an edit-first workflow./myron-polishto scan the current branch's diff againstmain, apply fixes directly (naming,respond_to?smells, DI pattern, load-bearing tests, RBS/YARD hygiene, etc.), and loop throughscript/lint --fix/script/spellcheck -w/script/type_check/script/run_gem_specs <gem>until a full iteration makes zero edits and all verification passes. Capped at 8 iterations.returnable: falsefield option #1108, Preserve highlighting forreturnable: falsefields #1120, Default highlightable? to false for returnable: false fields #1131, perf: Skip validation for registered query cache hits #1134, Treat shrink/split/clone source settings as read-only in normalizer #1144, Fix @key directive missing on deferred indexed types #1107.Test plan
/myron-polishin Claude Code./myron-polishon a branch with known violations and verify the loop terminates and the final report lists the edits.🤖 Generated with Claude Code