Fix nodes returning empty when only __typename is requested#1170
Merged
myronmarston merged 2 commits intoblock:mainfrom May 9, 2026
Merged
Conversation
When a query selects only `__typename` under `nodes` or `edges { node }`,
`requested_fields` ends up empty (because `__typename` is a dynamic field
and is stripped before populating `requested_fields`). This left
`individual_docs_needed: false`, causing `size: 0` in the datastore query
and returning no documents despite `total_edge_count > 0`.
Fix by additionally setting `individual_docs_needed: true` whenever
`nodes` or `edges.node` is selected at all — the client selecting that
part of the query is itself the signal that individual documents are needed.
Fixes block#1055
Generated with Claude Code
marcdaniels-toast
requested review from
BrianSigafoos-SQ,
ayousufi,
bsorbo,
jwils,
jwondrusch and
myronmarston
as code owners
myronmarston
requested changes
May 9, 2026
…uested Covers the fix from the previous commit at the unit level, as requested in code review. Generated with Claude Code
myronmarston
approved these changes
May 9, 2026
marcdaniels-toast
deleted the
mdaniels/fix-typename-only-query-returns-no-nodes
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a query selects only
__typenameundernodesoredges { node },requested_fieldsends up empty (because__typenameis a dynamic field and is stripped before populatingrequested_fields). This leftindividual_docs_needed: false, causingsize: 0in the datastore query and returning no documents despitetotal_edge_count > 0.Fix by additionally setting
individual_docs_needed: truewhenevernodesoredges.nodeis selected at all — the client selecting that part of the query is itself the signal that individual documents are needed.Fixes #1055