Expand myron-polish skill with frontmatter and new checklist sections#1283
Open
jwils wants to merge 2 commits into
Open
Expand myron-polish skill with frontmatter and new checklist sections#1283jwils wants to merge 2 commits into
jwils wants to merge 2 commits into
Conversation
849a36c to
62bf802
Compare
- Add skill frontmatter (name/description) so it surfaces in the skill list. - Add a "Pass 4 — Mechanical sweep" grep step for recurring themes (trailing whitespace, no-op churn, `#:` spacing, `_ =` casts, redundant `ElasticGraph::` prefixes, hardcoded derived type names). - Diff against a freshly fetched `origin/main` (or the PR's base branch), never local `main`, which can be stale and silently bloat the change set. - Run `script/quick_build` as a one-time final gate after the polish loop (too slow per-iteration), with guidance for distinguishing environmental datastore flakes from real cross-gem fallout. - Give the review-feedback step a concrete `gh api graphql` command for listing unresolved review threads. - New checklist sections: moves/namespace changes, extension mechanics, collections and small churn, and gems/dependencies. - Expand YARD+RBS and examples/generated-artifacts guidance, and the post-review-feedback reload step.
Distilled from the last month of review comments (PRs #1224, #1231, #1247, #1251, #1252): Code: - Polymorphism over `is_a?`/`instance_of?` type checks. - Core gems stay ignorant of extensions. - Fix the root cause across a category, not just the reported instance. - Comment non-obvious "why"; link a tracking issue for known limitations. Tests: - Tests must not be satisfiable by a degenerate constant return. - Make tests self-contained about details that matter. - Drive behavior through the public API, not internal collaborators. - Preserve full coverage when relocating tests.
62bf802 to
640a571
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the
myron-polishpre-review skill, distilling recurring themes from recent review history into the checklists.Commit 1 — frontmatter + structural additions
name/description) so the skill surfaces in the skill list and/myron-polishis discoverable.origin/main(or the PR's base branch) everywhere, never localmain— a stale localmainsilently turns "the diff" into thousands of unrelated files.#:annotations missing the space,_ =casts /respond_to?/alias_method/Struct.new/.select{}.map{}, redundantElasticGraph::prefixes insidemodule ElasticGraph, and hardcoded derived type names.script/quick_buildas a one-time final gate after the polish loop (too slow to run every iteration), to catch cross-gem fallout that per-gem runs miss — with guidance for distinguishing environmental datastore flakes from real fallout (re-run failures in isolation and compare against the base branch's failure profile), checking the exit code directly instead of piping throughtail, and booting the test datastore for integration/acceptance specs.gh api graphqlcommand in the review-feedback step for listing a PR's unresolved review threads.extendedhooks, reuse central mechanisms), collections & small churn (keepSetsemantics, targeted tests for incidental bug fixes, drop compatibility-shaped params), and gems & dependencies (runtime deps before dev deps, optional extensions stay optional).6.s →6./7.).Commit 2 — items distilled from the last month of reviews
Pulled from Myron's inline comments on PRs #1224, #1231, #1247, #1251, #1252:
Code checklist:
is_a?/instance_of?type checks (adapters/schema types are meant to be polymorphic).Tests checklist:
{},[],nil, one hardcoded case).