fix: align hamburger menu with macOS traffic light buttons#8300
Open
ayush-that wants to merge 2 commits intoblock:mainfrom
Open
fix: align hamburger menu with macOS traffic light buttons#8300ayush-that wants to merge 2 commits intoblock:mainfrom
ayush-that wants to merge 2 commits intoblock:mainfrom
Conversation
Signed-off-by: ayush-that <ayush1337@hotmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the macOS desktop header control positioning so the navigation “hamburger” button aligns with Electron’s macOS traffic light buttons (configured via trafficLightPosition in the main process).
Changes:
- Increase macOS-only left padding for the header controls (
pl-21→pl-[96px]). - Adjust the macOS header controls’ top offset (
top-[11px]→top-[15px]).
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dcaa9acc8f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: ayush-that <ayush1337@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adjusted the hamburger menu button positioning on macOS to properly align with the traffic light buttons. Increased horizontal padding (pl-21 → pl-[96px]) and corrected vertical offset (top-[11px] → top-[15px]).
Testing
Manual testing on macOS. Verified visual alignment of the hamburger button with traffic light circles in both expanded and collapsed navigation states.
Related Issues
Fixes #8299
Screenshots/Demos (for UX changes)
Before:
After:
Electron.mp4