fix(cli): display platform-correct secrets path in keyring config dialog#8328
Open
SushaanthSrinivasan wants to merge 1 commit intoblock:mainfrom
Open
fix(cli): display platform-correct secrets path in keyring config dialog#8328SushaanthSrinivasan wants to merge 1 commit intoblock:mainfrom
SushaanthSrinivasan wants to merge 1 commit intoblock:mainfrom
Conversation
The keyring configuration dialog hardcoded `~/.config/goose/secrets.yaml`
in its warning and confirmation messages. This path is only correct on
Linux. On Windows and macOS, the actual secrets file is in a different
location determined by the platform's config directory conventions.
Replace the hardcoded string with `Paths::config_dir().join("secrets.yaml")`
which is already imported and used elsewhere in the same file.
Fixes block#8326
Signed-off-by: SushaanthSrinivasan <SushaanthSrinivasan@users.noreply.github.com>
SushaanthSrinivasan
force-pushed
the
fix/configure-secrets-path-display
branch
from
69aa402 to
c907fa3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
goose configurehardcoded~/.config/goose/secrets.yamlin warning and confirmation messagesC:\Users\<user>\AppData\Roaming\Block\goose\config\secrets.yaml, on macOS it's~/Library/Application Support/Block/goose/Paths::config_dir().join("secrets.yaml"), which is already imported and used elsewhere in the same fileFixes #8326
Before / After
Before (hardcoded Unix path on Windows):
After (correct platform path):
Test plan
cargo check