fix: remove undefined union from optional header property types

maxholman · claude · maxholman · commit 20720b92d254 · 2026-04-23T21:01:19.000+07:00
The | undefined union on optional header properties broke the Command
generic constraint (Record&lt;string, string | number | boolean&gt;). The
hasQuestionToken (?) already expresses optionality.

Co-Authored-By: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/__tests__/__snapshots__/nullables.test.ts.snap b/__tests__/__snapshots__/nullables.test.ts.snap
@@ -23,7 +23,7 @@ exports[`header parameters 1`] = `
 export type UploadDataCommandHeader = {
         "content-type": "application/json" | "text/csv" | "application/xml";
         "content-length": number;
-        "x-idempotency-key"?: string | undefined;
+        "x-idempotency-key"?: string;
     };
 export type UploadDataCommandParams = {
         uploadId: string;
diff --git a/__tests__/fixtures/test1/commands.ts b/__tests__/fixtures/test1/commands.ts
@@ -3,7 +3,7 @@
  *
  * WARN: Do not edit directly.
  *
- * Generated on 2026-04-12T05:31:16.393Z
+ * Generated on 2026-04-23T13:57:43.818Z
  *
  */
 /** eslint-disable max-classes */
diff --git a/__tests__/fixtures/test1/enums.ts b/__tests__/fixtures/test1/enums.ts
@@ -3,7 +3,7 @@
  *
  * WARN: Do not edit directly.
  *
- * Generated on 2026-04-12T05:31:16.393Z
+ * Generated on 2026-04-23T13:57:43.818Z
  *
  */
 export const nullableStatus = ["active", "paused", "cancelled"] as const;
diff --git a/__tests__/fixtures/test1/hono-valibot.ts b/__tests__/fixtures/test1/hono-valibot.ts
@@ -3,7 +3,7 @@
  *
  * WARN: Do not edit directly.
  *
- * Generated on 2026-04-12T05:31:16.393Z
+ * Generated on 2026-04-23T13:57:43.818Z
  *
  */
 
diff --git a/__tests__/fixtures/test1/main.ts b/__tests__/fixtures/test1/main.ts
@@ -3,7 +3,7 @@
  *
  * WARN: Do not edit directly.
  *
- * Generated on 2026-04-12T05:31:16.393Z
+ * Generated on 2026-04-23T13:57:43.818Z
  *
  */
 import {
diff --git a/__tests__/fixtures/test1/types.ts b/__tests__/fixtures/test1/types.ts
@@ -3,7 +3,7 @@
  *
  * WARN: Do not edit directly.
  *
- * Generated on 2026-04-12T05:31:16.393Z
+ * Generated on 2026-04-23T13:57:43.818Z
  *
  */
 import type { Jsonifiable, Jsonify } from "type-fest";
@@ -217,7 +217,7 @@ export type LongRunningOperation =
 export type ImportBillingDataCommandHeader = {
 	"content-type": "application/json" | "text/csv" | "application/xml";
 	"content-length": number;
-	"x-idempotency-key"?: string | undefined;
+	"x-idempotency-key"?: string;
 };
 type ImportBillingDataCommandBodyApplicationOctetStream = NonNullable<
 	RequestInit["body"]
diff --git a/__tests__/fixtures/test1/valibot.ts b/__tests__/fixtures/test1/valibot.ts
@@ -3,7 +3,7 @@
  *
  * WARN: Do not edit directly.
  *
- * Generated on 2026-04-12T05:31:16.393Z
+ * Generated on 2026-04-23T13:57:43.818Z
  *
  */
 import * as v from "valibot";
diff --git a/lib/process-document.ts b/lib/process-document.ts
@@ -547,13 +547,7 @@ export async function processOpenApiDocument(
 												},
 											);
 
-											const resolvedType = hp.required
-												? type.type
-												: typeof type.type === "function"
-													? type.type
-													: type.type
-														? Writers.unionType(`${type.type}`, "undefined")
-														: undefined;
+											const resolvedType = type.type;
 
 											return {
 												...type,

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`*`
`4`	`4`	`* WARN: Do not edit directly.`
`5`	`5`	`*`
`6`		`- * Generated on 2026-04-12T05:31:16.393Z`
	`6`	`+ * Generated on 2026-04-23T13:57:43.818Z`
`7`	`7`	`*`
`8`	`8`	`*/`
`9`	`9`	`/** eslint-disable max-classes */`