Skip to content

Commit 90aa944

Browse files
committed
build: typecheck lib and bin sources in the test target
The test target ran a bare tsc against a tsconfig that only included __tests__, so type errors in lib/ and bin/ could slip through CI. Point the test config at ../lib and ../bin and make test depend on typecheck.
1 parent 3c5d734 commit 90aa944

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

Makefile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,7 @@ typecheck: node_modules tsconfig.json $(SRCS)
1515
pnpm exec tsc
1616

1717
.PHONY: test
18-
test: node_modules
19-
pnpm exec tsc
18+
test: node_modules typecheck
2019
pnpm exec vitest
2120

2221
node_modules: package.json

__tests__/tsconfig.json

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
11
{
22
"extends": "../tsconfig.json",
3-
"include": ["."]
3+
"compilerOptions": {
4+
"composite": false
5+
},
6+
"include": ["../lib", "../bin", "."],
7+
"exclude": ["node_modules"]
48
}

0 commit comments

Comments
 (0)