refactor: remove connected field from status, drop duplicate cli version

connected was only set in two explicit connector paths — wrong for
auto/relay modes and misleading when peers were present. Removed
from NodeState, NodeStatus, StatusResponse proto, REST API, REPL,
MCP, and OpenAPI spec. Peer count is the source of truth.

Also removed the redundant "cli:" version line from REPL info —
it was always identical to the daemon version in unified binary mode.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: maxholman

crates/api/src/handlers.rs

@@ -34,7 +34,6 @@ pub struct StatusResponse {
     pub version: String,
     pub role: String,
     pub uptime_ms: u64,
-    pub connected: bool,
     #[serde(skip_serializing_if = "Option::is_none")]
     pub peer_addr: Option<String>,
     #[serde(skip_serializing_if = "Option::is_none")]
@@ -157,7 +156,6 @@ pub async fn status(State(state): State<ApiState>) -> Result<Json<StatusResponse
                 version: s.version,
                 role,
                 uptime_ms: s.uptime_ms,
-                connected: s.connected,
                 peer_addr: if s.peer_addr.is_empty() {
                     None
                 } else {

crates/cli/src/output.rs

@@ -109,7 +109,6 @@ pub fn print_response(resp: &ManagementResponse) -> Result<(), CtlError> {
 
             println!("{:<18} {}", "name:", s.package_name);
             println!("{:<18} {}", "role:", role);
-            println!("{:<18} {}", "connected:", s.connected);
             if !s.peer_addr.is_empty() {
                 println!("{:<18} {}", "peer addr:", s.peer_addr);
             }
@@ -121,7 +120,6 @@ pub fn print_response(resp: &ManagementResponse) -> Result<(), CtlError> {
                 "capabilities:", s.tun_capable, s.listening, s.connecting
             );
             println!("{:<18} {}", "version:", s.version);
-            println!("{:<18} {}", "cli:", crate::version::version());
             println!("{:<18} {}", "uptime:", uptime);
         }
         Some(management_response::Response::Stats(s)) => {

crates/core/src/control/handler.rs

@@ -27,7 +27,6 @@ struct NodeState {
     role: NodeRole,
     capabilities: Capabilities,
     listen_addr: Option<SocketAddr>,
-    connected: bool,
     peer_addr: Option<String>,
 }
 
@@ -45,7 +44,6 @@ impl SharedNodeState {
             role,
             capabilities: Capabilities::default(),
             listen_addr: None,
-            connected: false,
             peer_addr: None,
         })))
     }
@@ -81,28 +79,6 @@ impl SharedNodeState {
             new
         });
     }
-
-    /// Record that the node has connected to a peer.
-    pub fn set_connected(&self, peer_addr: &str) {
-        let addr = peer_addr.to_string();
-        self.0.rcu(|old| {
-            let mut new = (**old).clone();
-            new.connected = true;
-            new.peer_addr = Some(addr.clone());
-            new.capabilities.connecting = true;
-            new
-        });
-    }
-
-    /// Record that the node has disconnected from its peer.
-    pub fn set_disconnected(&self) {
-        self.0.rcu(|old| {
-            let mut new = (**old).clone();
-            new.connected = false;
-            new.peer_addr = None;
-            new
-        });
-    }
 }
 
 /// Configuration for the control handler.
@@ -427,7 +403,6 @@ impl crate::node_api::NodeApi for Handler {
         let state = self.state.load();
         crate::node_api::NodeStatus {
             role: state.role,
-            connected: state.connected,
             peer_addr: state.peer_addr.clone(),
             capabilities: state.capabilities,
             listen_addr: state.listen_addr,
@@ -842,7 +817,6 @@ mod tests {
         assert!(!status.capabilities.tun_capable);
         assert!(!status.capabilities.listening);
         assert!(status.listen_addr.is_none());
-        assert!(!status.connected);
 
         // Simulate negotiation resolving to Entry.
         let state = handler.node_state();
@@ -864,19 +838,5 @@ mod tests {
         let status = crate::node_api::NodeApi::status(&handler);
         assert_eq!(status.listen_addr, Some(addr));
         assert!(status.capabilities.listening);
-
-        // Simulate connection.
-        state.set_connected("1.2.3.4:5678");
-
-        let status = crate::node_api::NodeApi::status(&handler);
-        assert!(status.connected);
-        assert_eq!(status.peer_addr.as_deref(), Some("1.2.3.4:5678"));
-
-        // Simulate disconnection.
-        state.set_disconnected();
-
-        let status = crate::node_api::NodeApi::status(&handler);
-        assert!(!status.connected);
-        assert!(status.peer_addr.is_none());
     }
 }

crates/core/src/ipc.rs

@@ -300,7 +300,7 @@ fn dispatch_request(request: &ManagementRequest, api: &dyn NodeApi) -> Managemen
             let s = api.status();
             management_response::Response::Status(StatusResponse {
                 role: management::NodeRole::from(s.role).into(),
-                connected: s.connected,
+                connected: false, // deprecated — derive from peer count instead
                 peer_addr: s.peer_addr.unwrap_or_default(),
                 listen_addr: s.listen_addr.map_or_else(String::new, |a| a.to_string()),
                 version: s.version,

crates/core/src/node_api.rs

@@ -85,8 +85,6 @@ pub struct Metrics {
 pub struct NodeStatus {
     /// Node's role.
     pub role: NodeRole,
-    /// Whether node is connected to a peer (for exit/relay).
-    pub connected: bool,
     /// Peer address (if connected).
     pub peer_addr: Option<String>,
     /// Advertised capabilities.

crates/daemon/src/mode/entry.rs

@@ -187,11 +187,7 @@ pub async fn run(
             "entry nodes do not support both connect and listen simultaneously".into(),
         )),
         ConnectivitySpec::Listen(spec) => run_entry_listen(global, cfg, spec, res).await,
-        ConnectivitySpec::Connect(spec) => {
-            let node_state = res.node_state.clone();
-            node_state.set_connected(&spec.addr);
-            run_entry_connect(global, cfg, spec, res).await
-        }
+        ConnectivitySpec::Connect(spec) => run_entry_connect(global, cfg, spec, res).await,
     }
 }
 

crates/daemon/src/mode/exit.rs

@@ -74,7 +74,6 @@ pub async fn run(
                 .into(),
         )),
         ConnectivitySpec::Connect(spec) => {
-            ctx.node_state.set_connected(&spec.addr);
             run_exit_connector(global, &cfg.name, spec, &security, &ctx).await
         }
         ConnectivitySpec::Listen(spec) => run_exit_listener(global, &cfg.name, spec, &ctx).await,

crates/mcp/src/convert.rs

@@ -12,7 +12,6 @@ pub fn format_response(resp: &ManagementResponse) -> Result<String, String> {
             let mut out = String::new();
             let _ = writeln!(out, "name: {}", s.package_name);
             let _ = writeln!(out, "role: {role}");
-            let _ = writeln!(out, "connected: {}", s.connected);
             if !s.peer_addr.is_empty() {
                 let _ = writeln!(out, "peer addr: {}", s.peer_addr);
             }

website/src/data/openapi.json

@@ -27,7 +27,6 @@
 					"version",
 					"role",
 					"uptime_ms",
-					"connected",
 					"capabilities"
 				],
 				"properties": {
@@ -48,10 +47,6 @@
 						"type": "integer",
 						"description": "Node uptime in milliseconds."
 					},
-					"connected": {
-						"type": "boolean",
-						"description": "Whether the node has an active peer connection."
-					},
 					"peer_addr": {
 						"type": "string",
 						"description": "Remote peer address (present only when connected)."