fix clang compatiblity when building with gcc#311
Open
fran6co wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks @fran6co. What issue is this fixing? We don't see a problem with the |
Author
|
This fixes what #301 describes, for some reason the clang and the gcc codes are different so if I compile bde with gcc (like it does with vcpkg on linux) and then I have a project using clang the 2 implementations are going to be different and create the undefined error mentioned in the issue above |
Author
|
if you build with clang all the way, then there is no problem |
Contributor
|
Ah, I missed the "Fixes #301" comment in your initial PR, my apologies. We'll take a look at this, thanks. |
Contributor
|
This is being tracked in internal ticket 181481200 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #301
Describe your changes
Just moves calls from header to source
Testing performed
Built with vcpkg and then linked used clang