Removing requirements-*.txt files in favor of dep groups#926
Open
grantlouisherman wants to merge 1 commit into
Open
Removing requirements-*.txt files in favor of dep groups#926grantlouisherman wants to merge 1 commit into
grantlouisherman wants to merge 1 commit into
Conversation
grantlouisherman
force-pushed
the
remove-requirements-dep-groups
branch
from
8346276 to
0673da9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #926 +/- ##
==========================================
- Coverage 92.43% 92.40% -0.03%
==========================================
Files 99 99
Lines 11785 11785
Branches 429 429
==========================================
- Hits 10893 10890 -3
- Misses 892 895 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: grantlouisherman <grantlouisherman041@gmail.com>
grantlouisherman
force-pushed
the
remove-requirements-dep-groups
branch
from
139d4cc to
e7b3c3a
Compare
|
|
||
| [dependency-groups] | ||
| test=['Cython', 'coverage[toml]', "greenlet; python_version < '3.14'", 'pytest', 'pytest-cov', 'ipython', 'setuptools', 'pkgconfig', 'pytest-textual-snapshot', 'textual >= 0.43, != 0.65.2, != 0.66', 'packaging'] | ||
| docs=['mypy', 'bump2version','towncrier', 'pre-commit', {include-group = "test"}] |
Author
There was a problem hiding this comment.
In the original there was a requirement from extra to docs, but they essentially have the same dependencies so I just made them the same. Obviously this is no DRY but I dont think there is a good way to do variables in pyproject tomls?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*Issue number of the reported bug or feature request: #919
Describe your changes
I removed requirements-*.txt in favor or using dep groups
Testing performed
Automated testing