Skip to content

Removing requirements-*.txt files in favor of dep groups#926

Merged
godlygeek merged 1 commit into
bloomberg:mainfrom
grantlouisherman:remove-requirements-dep-groups
May 21, 2026
Merged

Removing requirements-*.txt files in favor of dep groups#926
godlygeek merged 1 commit into
bloomberg:mainfrom
grantlouisherman:remove-requirements-dep-groups

Conversation

@grantlouisherman
Copy link
Copy Markdown
Contributor

*Issue number of the reported bug or feature request: #919

Describe your changes
I removed requirements-*.txt in favor or using dep groups

Testing performed
Automated testing

@grantlouisherman grantlouisherman force-pushed the remove-requirements-dep-groups branch from 8346276 to 0673da9 Compare May 18, 2026 20:10
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.41%. Comparing base (ee6a65d) to head (577ec2b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #926      +/-   ##
==========================================
- Coverage   92.43%   92.41%   -0.02%     
==========================================
  Files          99       99              
  Lines       11785    11785              
  Branches      429      429              
==========================================
- Hits        10893    10891       -2     
- Misses        892      894       +2     
Flag Coverage Δ
cpp 92.41% <ø> (-0.02%) ⬇️
python_and_cython 92.41% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@grantlouisherman grantlouisherman marked this pull request as ready for review May 18, 2026 23:45
@grantlouisherman grantlouisherman force-pushed the remove-requirements-dep-groups branch from 139d4cc to e7b3c3a Compare May 18, 2026 23:49
Comment thread pyproject.toml Outdated
Comment thread pyproject.toml Outdated
@grantlouisherman grantlouisherman force-pushed the remove-requirements-dep-groups branch 3 times, most recently from 4c6da8a to a38d82c Compare May 19, 2026 19:43
@sarahmonod sarahmonod linked an issue May 19, 2026 that may be closed by this pull request
@grantlouisherman grantlouisherman force-pushed the remove-requirements-dep-groups branch from 419de19 to 4d086db Compare May 19, 2026 23:29
@grantlouisherman
Copy link
Copy Markdown
Contributor Author

@godlygeek should be good now .... I hope

Comment thread Dockerfile
Comment thread README.md Outdated
Copy link
Copy Markdown
Contributor

@godlygeek godlygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @grantlouisherman !

Dependency groups are the latest and greatest way to manage the
dependencies of a project needed only by contributors.

Signed-off-by: Grant Herman <grantlouisherman041@gmail.com>
Co-authored-by: Matt Wozniski <godlygeek@gmail.com>
@godlygeek godlygeek force-pushed the remove-requirements-dep-groups branch from 88cab3f to 577ec2b Compare May 21, 2026 02:23
@godlygeek godlygeek enabled auto-merge (rebase) May 21, 2026 02:24
@godlygeek godlygeek merged commit fb215dd into bloomberg:main May 21, 2026
19 checks passed
@grantlouisherman grantlouisherman deleted the remove-requirements-dep-groups branch May 25, 2026 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch from requirements-*.txt files to to dependency groups

3 participants