Skip to content

Commit fae934d

Browse files
committed
ci: Switch from zizmor.yml to inline comments
Rather than recording which zizmor rules are being skipped in a separate config file, inline that configuration into the workflows themselves as comments, to avoid needing to constantly update an extra file as new lines are added or removed from the workflow. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
1 parent a88a6eb commit fae934d

3 files changed

Lines changed: 6 additions & 18 deletions

File tree

.github/workflows/build_wheels.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@ jobs:
289289
fail-fast: false
290290

291291
container:
292-
image: alpine
292+
image: alpine # zizmor: ignore[unpinned-images]
293293
options: --cap-add=SYS_PTRACE
294294

295295
steps:
@@ -321,7 +321,7 @@ jobs:
321321
fail-fast: false
322322

323323
container:
324-
image: fedora
324+
image: fedora # zizmor: ignore[unpinned-images]
325325
options: --cap-add=SYS_PTRACE
326326

327327
steps:
@@ -359,7 +359,7 @@ jobs:
359359
fail-fast: false
360360

361361
container:
362-
image: archlinux
362+
image: archlinux # zizmor: ignore[unpinned-images]
363363
options: --cap-add=SYS_PTRACE --security-opt seccomp=unconfined
364364
steps:
365365
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
@@ -400,7 +400,7 @@ jobs:
400400
fail-fast: false
401401

402402
container:
403-
image: debian
403+
image: debian # zizmor: ignore[unpinned-images]
404404
options: --cap-add=SYS_PTRACE
405405

406406
steps:

.github/workflows/coverage.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,12 +71,12 @@ jobs:
7171
- name: Upload Python report to Codecov
7272
uses: codecov/codecov-action@e79a6962e0d4c0c17b229090214935d2e33f8354 # v6
7373
with:
74-
token: ${{ secrets.CODECOV_TOKEN }}
74+
token: ${{ secrets.CODECOV_TOKEN }} # zizmor: ignore[secrets-outside-env]
7575
files: pycoverage.lcov
7676
flags: python
7777
- name: Upload C++ report to Codecov
7878
uses: codecov/codecov-action@e79a6962e0d4c0c17b229090214935d2e33f8354 # v6
7979
with:
80-
token: ${{ secrets.CODECOV_TOKEN }}
80+
token: ${{ secrets.CODECOV_TOKEN }} # zizmor: ignore[secrets-outside-env]
8181
files: cppcoverage.lcov
8282
flags: cpp

zizmor.yml

Lines changed: 0 additions & 12 deletions
This file was deleted.

0 commit comments

Comments
 (0)