Create --native-last arg#182
Merged
Merged
Conversation
sarahmonod
force-pushed
the
create-native-last-mode
branch
3 times, most recently
from
0b3002d to
bbe728c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #182 +/- ##
==========================================
+ Coverage 82.66% 82.73% +0.06%
==========================================
Files 46 46
Lines 6249 6272 +23
Branches 458 461 +3
==========================================
+ Hits 5166 5189 +23
Misses 1083 1083
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sarahmonod
force-pushed
the
create-native-last-mode
branch
2 times, most recently
from
29bd880 to
11fcaa5
Compare
godlygeek
force-pushed
the
create-native-last-mode
branch
from
11fcaa5 to
3f748b9
Compare
godlygeek
force-pushed
the
create-native-last-mode
branch
from
3f748b9 to
270c2a9
Compare
Each of these removed tests is identical to one of the parametrizations of the test above it. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
Signed-off-by: Sarah Monod <smonod1@bloomberg.net>
godlygeek
force-pushed
the
create-native-last-mode
branch
from
270c2a9 to
c95594c
Compare
godlygeek
approved these changes
Jul 15, 2025
Contributor
godlygeek
left a comment
godlygeek
left a comment
There was a problem hiding this comment.
LGTM. Sorry for the long delay on getting this landed, but this looks great and I'm landing it now. Thanks @Kretzer6019!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: #142
Describe your changes
Created a new arg called
--native-last, which shows only C frames after the last printed python frame. This helps to reduce verbose when trying to puzzle out deadlocks and blocking happening in the C code, where last frames might be enouth.Testing performed
Added
test_traceback_formatter_only_last_native_framesto ensure that the new mode will show only the last C frames after the last python printed frame.Additional context
Add any other context about your contribution here.