Fix security-related issues in github actions flagged by zizmor#292
Fix security-related issues in github actions flagged by zizmor#292peytondmurray wants to merge 9 commits into
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #292 +/- ##
=======================================
Coverage 79.22% 79.22%
=======================================
Files 51 51
Lines 5550 5550
Branches 581 581
=======================================
Hits 4397 4397
Misses 1153 1153
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| container: | ||
| image: fedora | ||
| image: fedora@f717d3f59ea0 |
There was a problem hiding this comment.
Looks like this format isn't valid and the build fails.
We chatted about this with @godlygeek and it would be good to leverage Dependabot for keeping the Docker images up to date as well. It seems it's supported.
There was a problem hiding this comment.
Great, I've added the Docker section to the dependabot config. It sounds like we also need labels on each image if we want downstream projects that rely on dependabot to pull in metadata about new releases. I've added
LABEL org.opencontainers.image.source="https://github.com/bloomberg/pystack"to the last image to do this.
The other thing is that the Dependabot config only works if
maintainers must tag the repository with the same tags as the published Docker images. For an example, see the dependabot-fixtures/docker-with-source repository.
I assume they're talking about git tags, right?
93ad9b4 to
d4a010b
Compare
|
I know this was already the case before this PR, but I don't like the fact that the upload and download actions are of different versions. Can you please check if the latest version for both of them works together? |
|
Sure! I figured I'd let dependabot take care of it, but I'd be happy to update all of the actions, which probably makes the most sense. |
Signed-off-by: pdmurray <peynmurray@gmail.com>
Signed-off-by: pdmurray <peynmurray@gmail.com>
Signed-off-by: pdmurray <peynmurray@gmail.com>
Signed-off-by: pdmurray <peynmurray@gmail.com>
Signed-off-by: pdmurray <peynmurray@gmail.com>
Signed-off-by: pdmurray <peynmurray@gmail.com>
Signed-off-by: pdmurray <peynmurray@gmail.com>
Signed-off-by: pdmurray <peynmurray@gmail.com>
Signed-off-by: pdmurray <peynmurray@gmail.com>
cd6024b to
a49f153
Compare
|
Okay, after a few minutes investigation it seems like there is currently a version discrepancy between actions/upload-artifact and actions/download-artifact. So this is fine as is, and in fact it is configured in accordance with the download-artifact usage instructions: https://github.com/actions/download-artifact#download-multiple-filtered-artifacts-to-the-same-directory I did take the opportunity to bump the setup-uv action to v8, though. |
Issue number of the reported bug or feature request: Closes #287.
Describe your changes
This PR addresses a number of security-related issues in the github actions (and dependabot config) that were flagged by zizmor. Most of the changes are:
This PR also adds a zizmor action to ensure these issues don't arise in the future.
Note that the container images used during the wheel builds workflow remain unpinned. After weighing the dangers of running a compromised container here, it was decided that the effort of keeping pinned containers up to date was not worth the effort. As a result we have zizmor configured to ignore these rule violations here.
Testing performed
This will be tested by running the CI in this PR.