Skip to content

Pin the pre-commit hook hashes#294

Merged
sarahmonod merged 2 commits into
bloomberg:mainfrom
peytondmurray:293-pre-commit-freeze
May 19, 2026
Merged

Pin the pre-commit hook hashes#294
sarahmonod merged 2 commits into
bloomberg:mainfrom
peytondmurray:293-pre-commit-freeze

Conversation

@peytondmurray
Copy link
Copy Markdown
Contributor

Issue number of the reported bug or feature request: Closes #293.

Describe your changes
This PR pins (and updates) the pre-commit hooks using commit hashes rather than (potentially mutable) git refs. For future reference, the command used here was pre-commit autoupdate --freeze.

Testing performed
No testing required.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 18, 2026

Codecov Report

❌ Patch coverage is 91.54930% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.19%. Comparing base (debc9e8) to head (257f103).

Files with missing lines Patch % Lines
src/pystack/_pystack/corefile.cpp 0.00% 2 Missing ⚠️
src/pystack/_pystack/corefile.h 0.00% 1 Missing ⚠️
src/pystack/_pystack/pytypes.cpp 0.00% 1 Missing ⚠️
src/pystack/_pystack/unwinder.h 0.00% 1 Missing ⚠️
tests/utils.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #294   +/-   ##
=======================================
  Coverage   79.19%   79.19%           
=======================================
  Files          51       51           
  Lines        5542     5542           
  Branches      577      580    +3     
=======================================
  Hits         4389     4389           
  Misses       1153     1153           
Flag Coverage Δ
cpp 79.19% <91.54%> (ø)
python 79.19% <91.54%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: pdmurray <peynmurray@gmail.com>
Co-authored-by: Sarah Monod <smonod1@bloomberg.net>
@sarahmonod sarahmonod force-pushed the 293-pre-commit-freeze branch from ea5ec26 to 7a5db2b Compare May 18, 2026 23:47
Signed-off-by: pdmurray <peynmurray@gmail.com>
@peytondmurray
Copy link
Copy Markdown
Contributor Author

It looks like the newly updated pre-commit hooks resulted in a few formatting changes, some of which hit example python files used by tests. This means that there are some line number changes for a few of the integration tests. These should now be up to date with the latest changes 👍

@peytondmurray
Copy link
Copy Markdown
Contributor Author

Does it make sense to write a news entry for this?

@sarahmonod
Copy link
Copy Markdown
Contributor

Does it make sense to write a news entry for this?

Nope, I've added the skip news label for it.

@sarahmonod sarahmonod merged commit 66bc46c into bloomberg:main May 19, 2026
31 of 32 checks passed
@peytondmurray peytondmurray deleted the 293-pre-commit-freeze branch May 20, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use prek instead of pre-commit

3 participants