Skip to content

Upgrade CMAKE_CXX_STANDARD to 20#308

Merged
sarahmonod merged 1 commit into
bloomberg:mainfrom
scopreon:cpp20-upgrade
May 20, 2026
Merged

Upgrade CMAKE_CXX_STANDARD to 20#308
sarahmonod merged 1 commit into
bloomberg:mainfrom
scopreon:cpp20-upgrade

Conversation

@scopreon
Copy link
Copy Markdown
Contributor

Issue number of the reported bug or feature request: NAN

Describe your changes
Upgrade supported C++ version from 17 to 20

Testing performed
CI should pass

Additional context
Add any other context about your contribution here.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.19%. Comparing base (debc9e8) to head (d749a45).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #308   +/-   ##
=======================================
  Coverage   79.19%   79.19%           
=======================================
  Files          51       51           
  Lines        5542     5542           
  Branches      577      577           
=======================================
  Hits         4389     4389           
  Misses       1153     1153           
Flag Coverage Δ
cpp 79.19% <ø> (ø)
python 79.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Saul Cooperman <saulcoops@gmail.com>
@sarahmonod
Copy link
Copy Markdown
Contributor

This looks good to me in principle, but I'm not sure why we were using C++17 to begin with, so I'd like Matt's input

@godlygeek
Copy link
Copy Markdown
Contributor

I'm reasonably convinced that our CI would catch any problems with this. The fact that we were able to successfully produce manylinux_2_17 and musllinux_1_2 wheels means that this doesn't introduce any runtime dependencies on newer versions of libstdc++ or libc than we're able to depend upon, which would have been my only concern about upgrading.

So, I think this is safe... any objections, @pablogsal?

@pablogsal
Copy link
Copy Markdown
Collaborator

No concerns, we have done this with cpp17 in the past iirc with no problems as well

Copy link
Copy Markdown
Contributor

@sarahmonod sarahmonod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @scopreon !

@sarahmonod sarahmonod merged commit 4bcc46b into bloomberg:main May 20, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants