Upgrade CMAKE_CXX_STANDARD to 20#308
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #308 +/- ##
=======================================
Coverage 79.19% 79.19%
=======================================
Files 51 51
Lines 5542 5542
Branches 577 577
=======================================
Hits 4389 4389
Misses 1153 1153
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Saul Cooperman <saulcoops@gmail.com>
|
This looks good to me in principle, but I'm not sure why we were using C++17 to begin with, so I'd like Matt's input |
|
I'm reasonably convinced that our CI would catch any problems with this. The fact that we were able to successfully produce So, I think this is safe... any objections, @pablogsal? |
|
No concerns, we have done this with cpp17 in the past iirc with no problems as well |
sarahmonod
left a comment
There was a problem hiding this comment.
LGTM, thanks @scopreon !
Issue number of the reported bug or feature request: NAN
Describe your changes
Upgrade supported C++ version from 17 to 20
Testing performed
CI should pass
Additional context
Add any other context about your contribution here.