ci: Switch from zizmor.yml to inline comments#311
Open
godlygeek wants to merge 2 commits into
Open
Conversation
Rather than recording which zizmor rules are being skipped in a separate config file, inline that configuration into the workflows themselves as comments, to avoid needing to constantly update an extra file as new lines are added or removed from the workflow. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #311 +/- ##
=======================================
Coverage 79.19% 79.19%
=======================================
Files 51 51
Lines 5561 5561
Branches 583 583
=======================================
Hits 4404 4404
Misses 1157 1157
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This is required for zizmor to be able to upload the SARIF files used for CodeQL to GitHub. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than recording which zizmor rules are being skipped in a separate config file, inline that configuration into the workflows themselves as comments, to avoid needing to constantly update an extra file as new lines are added or removed from the workflow.