fix(query): sort FieldIndex via jsonb -> (#158)#159
Merged
Conversation
#158) Text operator `idx->>'{key}'` casts to TEXT before ORDER BY, so a FieldIndex over a numeric attribute ranked "10" before "2". The jsonb operator `idx->'{key}'` preserves type — numbers sort numerically, strings lexically — so homogeneous FieldIndexes sort correctly regardless of value type. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #158.
Summary
_process_sortnow emitsidx->'{key}'(jsonb operator) instead ofidx->>'{key}'(text operator) for theFieldIndexfallback."10" < "2". JSONB comparison is type-aware — numbers sort numerically, strings lexically.FieldIndexwith numeric source data (counters, priorities, prices, weights). Standard Plone columns (sortable_title,portal_type, …) are strings and sort the same as before.Scope
Only the
FieldIndex/fallback branch of_process_sort.DATE,BOOLEAN,GOPIPalready cast explicitly and keep their current expressions. Dedicatedpathcolumn unchanged.Low-prio sort gaps uncovered during the audit (
allowedRolesAndUsersExtraIdxColumn TEXT[] no-op,effectiveRange,SearchableText) are collected in #157 — not in this PR.Test plan
test_sort_field_uses_jsonb_operatorasserts the operator switch[10, 2, 20, 3, 1]sorts1, 2, 3, 10, 20(would have been1, 10, 2, 20, 3before)🤖 Generated with Claude Code