Skip to content

fix: get the languages from plone registry and not from portal_languages #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jensens merged 4 commits into from
Jun 15, 2026
Merged

fix: get the languages from plone registry and not from portal_languages #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c16a11d
fix: get the languages from plone registry and not from portal_languages
erral May 13, 2026
10df10a
chore: remove portal_type detection
erral May 13, 2026
e456eb4
Merge remote-tracking branch 'origin/main' into erral-bm25-language-d…
jensens Jun 15, 2026
3a2e997
style: restore blank line after imports (ruff I001)
jensens Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@

### Fixed

- Fix automatic language detection for BM25 ranking #164

- PG-backed test layer: reset zodb_pgjsonb's process-wide
``SharedLoadCache`` between tests. The per-test ``restore()`` rolls
the database backwards to a snapshot, but ``cacheMinimize()`` /
Expand Down
6 changes: 3 additions & 3 deletions src/plone/pgcatalog/startup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,9 @@ def _detect_languages_from_db(db): # pragma: no cover
root = conn.root()
app = root.get("Application", root)
for obj in app.values():
lang_tool = getattr(obj, "portal_languages", None)
if lang_tool is not None:
langs = list(lang_tool.getSupportedLanguages())
portal_registry = getattr(obj, "portal_registry", None)
if portal_registry is not None:
langs = portal_registry.get("plone.available_languages", [])
if langs:
log.info(
"Auto-detected BM25 languages from %s: %s",
Expand Down
Loading