fix(zmi): show configured slow-query threshold in empty state#196
Merged
Conversation
The Slow Queries tab's 'no slow queries yet' message hard-coded the PGCATALOG_SLOW_QUERY_MS env var name and its default of 10ms. The actual configured value is more useful, and manage_get_slow_query_threshold() (already used for the header) exposes it. Show that instead. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Slow Queries tab's empty-state message hard-coded the env var name and its default:
The actually-configured threshold is more useful than the default.
manage_get_slow_query_threshold()(already used for the tab header) returns it, so the message now reads e.g. "Queries exceeding the configured threshold (25ms, set viaPGCATALOG_SLOW_QUERY_MS) …".tests/test_slow_queries_view.py: asserts the empty state uses the dynamic threshold and no longer hard-codesdefault 10ms.🤖 Generated with Claude Code