Apply modernizations from 'go fix' (#154)

Author: bluekeyes

applier_test.go

@@ -123,8 +123,8 @@ func assertPatchResult(t *testing.T, tctx *TestContext, name string, c *github.C
 		}
 
 		relpath := filepath.ToSlash(strings.TrimPrefix(path, root))
-		if strings.HasSuffix(relpath, DeletedExt) {
-			delete(expected, strings.TrimSuffix(relpath, DeletedExt))
+		if path, ok := strings.CutSuffix(relpath, DeletedExt); ok {
+			delete(expected, path)
 			return nil
 		}
 

cmd/patch2pr/main.go

@@ -214,8 +214,8 @@ func execute(ctx context.Context, client *github.Client, patchFiles []string, op
 		}
 	}
 
-	if strings.HasPrefix(patchBase, "refs/") {
-		ref, _, err := client.Git.GetRef(ctx, targetRepo.Owner, targetRepo.Name, strings.TrimPrefix(patchBase, "refs/"))
+	if baseRef, ok := strings.CutPrefix(patchBase, "refs/"); ok {
+		ref, _, err := client.Git.GetRef(ctx, targetRepo.Owner, targetRepo.Name, baseRef)
 		if err != nil {
 			return nil, fmt.Errorf("get ref for patch base %q failed: %w", patchBase, err)
 		}

cmd/patch2pr/mbox.go

@@ -74,7 +74,7 @@ func (r *mboxMessageReader) Read(p []byte) (n int, err error) {
 }
 
 func (r *mboxMessageReader) scanForHeader(p []byte, n int) int {
-	for i := 0; i < n; i++ {
+	for i := range n {
 		if isSpace(p[i]) {
 			r.isLineStart = p[i] == '\n'
 			continue

error.go

@@ -5,7 +5,7 @@ import (
 	"fmt"
 )
 
-func unsupported(msg string, args ...interface{}) error {
+func unsupported(msg string, args ...any) error {
 	return unsupportedErr{reason: fmt.Sprintf(msg, args...)}
 }
 

graphql_applier.go

@@ -200,7 +200,7 @@ func (a *GraphQLApplier) getContent(ctx context.Context, filePath string) ([]byt
 			} `graphql:"object(expression: $expr)"`
 		} `graphql:"repository(owner: $owner, name: $name)"`
 	}
-	vars := map[string]interface{}{
+	vars := map[string]any{
 		"owner": githubv4.String(a.owner),
 		"name":  githubv4.String(a.repo),
 		"expr":  githubv4.String(fmt.Sprintf("%s:%s", a.commit, filePath)),
@@ -249,7 +249,7 @@ func (a *GraphQLApplier) getMode(ctx context.Context, filePath string) (os.FileM
 			} `graphql:"object(expression: $expr)"`
 		} `graphql:"repository(owner: $owner, name: $name)"`
 	}
-	vars := map[string]interface{}{
+	vars := map[string]any{
 		"owner": githubv4.String(a.owner),
 		"name":  githubv4.String(a.repo),
 		"expr":  githubv4.String(fmt.Sprintf("%s:%s", a.commit, treePath(filePath))),