core: frontend: kraken: StoreExtensionCard: Fix cross problem#3395
core: frontend: kraken: StoreExtensionCard: Fix cross problem#3395patrickelectric wants to merge 1 commit into
Conversation
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Reviewer's GuideModifies StoreExtensionCard.vue to prepend a CORS proxy URL to the extension_logo src, resolving cross-domain image loading issues. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @patrickelectric - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `core/frontend/src/components/kraken/cards/StoreExtensionCard.vue:53` </location>
<code_context>
ref="extension_logo"
contain
- :src="extension.extension_logo"
+ :src="'https://corsproxy.io/?url=' + extension.extension_logo"
height="150px"
class="mt-3 mb-5 my-2 logo-img"
</code_context>
<issue_to_address>
Using a public CORS proxy for image loading introduces reliability and security concerns.
Third-party proxies like corsproxy.io may be unreliable and pose security risks. It's better to manage CORS on your backend or use a proxy you control.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| ref="extension_logo" | ||
| contain | ||
| :src="extension.extension_logo" | ||
| :src="'https://corsproxy.io/?url=' + extension.extension_logo" |
There was a problem hiding this comment.
🚨 issue (security): Using a public CORS proxy for image loading introduces reliability and security concerns.
Third-party proxies like corsproxy.io may be unreliable and pose security risks. It's better to manage CORS on your backend or use a proxy you control.
joaoantoniocardoso
left a comment
There was a problem hiding this comment.
Be aware that if we are using it on the free tier (which is meant for development), they say:
- it has a rate limit of 60 per minute (per IP), which means this will be a temporary fix.
- it is limited to localhost, which means it might not work on our BlueOS live preview.
Oh sad.. |
|
We may need to upload our stuff to Amazon or start having our own git mirror |
|
This probably will work as a temporary fix as @joaoantoniocardoso mentioned, the code seems to work ok, but I also agree that maybe uploading to other place will be better. |
|
was this fixed by bluerobotics/BlueOS-Extensions-Repository#147? |
Summary by Sourcery
Bug Fixes: