views: general-settings: replace telemetry switch with data sharing modal

Add a "Shared Data" entry point in General settings that opens the new
data privacy modal, and remove the legacy "Usage statistics telemetry"
switch from Dev settings - it was the only consumer of the
`enableUsageStatisticsTelemetry` ref, which now belongs to the modal
through plain `localStorage`.

Drop the corresponding `useStorage` registration from the development
store so the settings manager no longer claims ownership of the boolean
and cannot stomp the value the modal writes.

Author: ArturoManzoli

src/stores/development.ts

@@ -1,28 +1,39 @@
 import { useStorage } from '@vueuse/core'
 import { defineStore } from 'pinia'
-import { ref } from 'vue'
+import { ref, watch } from 'vue'
 
 import { useBlueOsStorage } from '@/composables/settingsSyncer'
+import { defaultShareHardwareDetails, shareHardwareDetailsKey } from '@/libs/external-telemetry/event-tracking'
+import { settingsManager } from '@/libs/settings-management'
 
 export const systemLoggingEnablingKey = 'cockpit-enable-system-logging'
 export const blueOsSettingsSyncEnablingKey = 'cockpit-enable-blueos-settings-sync'
-export const enableUsageStatisticsTelemetryKey = 'cockpit-enable-usage-statistics-telemetry'
 export const showSplashScreenOnStartupKey = 'cockpit-show-splash-screen-on-startup'
 
 export const useDevelopmentStore = defineStore('development', () => {
   const developmentMode = ref(false)
   const widgetDevInfoBlurLevel = ref(3)
   const enableSystemLogging = useBlueOsStorage(systemLoggingEnablingKey, true)
   const enableBlueOsSettingsSync = useStorage(blueOsSettingsSyncEnablingKey, true)
-  const enableUsageStatisticsTelemetry = useStorage(enableUsageStatisticsTelemetryKey, true)
   const showSplashScreenOnStartup = useStorage(showSplashScreenOnStartupKey, true)
 
+  const shareHardwareDetails = ref<boolean>(
+    settingsManager.getKeyValue<boolean>(shareHardwareDetailsKey) ?? defaultShareHardwareDetails
+  )
+  watch(shareHardwareDetails, (newValue) => {
+    settingsManager.setKeyValue(shareHardwareDetailsKey, newValue, Date.now())
+  })
+  settingsManager.registerListener(shareHardwareDetailsKey, (newSetting) => {
+    const newValue = newSetting.value as boolean
+    if (newValue !== shareHardwareDetails.value) shareHardwareDetails.value = newValue
+  })
+
   return {
     developmentMode,
     widgetDevInfoBlurLevel,
     enableSystemLogging,
     enableBlueOsSettingsSync,
-    enableUsageStatisticsTelemetry,
+    shareHardwareDetails,
     showSplashScreenOnStartup,
   }
 })

src/views/ConfigurationDevelopmentView.vue

@@ -26,14 +26,6 @@
               class="min-w-[155px]"
               @update:model-value="reloadCockpitAndWarnUser()"
             />
-            <v-switch
-              v-model="devStore.enableUsageStatisticsTelemetry"
-              label="Usage statistics telemetry"
-              color="white"
-              hide-details
-              class="min-w-[155px]"
-              @update:model-value="reloadCockpitAndWarnUser()"
-            />
             <v-switch
               v-model="devStore.enableSystemLogging"
               label="Enable system logging"

src/views/ConfigurationGeneralView.vue

@@ -40,7 +40,7 @@
                 </div>
               </div>
               <v-divider class="w-full opacity-[0.08]" />
-              <div class="flex flex-row w-full items-center justify-between py-5 gap-x-2">
+              <div class="flex flex-row w-full items-center justify-between py-3 gap-x-2 gap-y-3 flex-wrap">
                 <v-btn size="x-small" class="bg-[#FFFFFF22] shadow-1" variant="flat" @click="openTutorial">
                   Show tutorial
                 </v-btn>
@@ -63,6 +63,15 @@
                 <v-btn size="x-small" class="bg-[#FFFFFF22] shadow-1" variant="flat" @click="openExternalFeaturesModal">
                   Extension features
                 </v-btn>
+                <v-btn
+                  size="x-small"
+                  class="bg-[#FFFFFF22] shadow-1"
+                  variant="flat"
+                  prepend-icon="mdi-shield-lock-outline"
+                  @click="interfaceStore.isDataPrivacyModalVisible = true"
+                >
+                  Shared Data
+                </v-btn>
               </div>
               <v-divider v-if="isElectron()" class="w-full opacity-[0.08]" />
               <div v-if="isElectron()" class="flex flex-col w-full py-4 gap-1">